fix: Add condition to hide validation error for unmatching passwords when required condition is present

[bistaastha]

Summary by CodeRabbit

• Bug Fixes
  • Improved password confirmation error message display logic to provide more precise validation feedback

[coderabbitai]

Walkthrough

In a swift and stylish move, the pull request refines the error message display logic for password confirmation in the new password form. The change subtly adjusts the conditional rendering to ensure that the "Passwords do not match" message appears only under precise validation conditions, adding an extra layer of precision to the form's error handling mechanism.

Changes

File	Change Summary
src/app/auth/new-password/new-password.page.html	Modified error message display condition to check for passwordMismatch error while excluding required error

Suggested Reviewers

• arjunaj5
• Chethan-Fyle

Suggested Labels

size/XS

Poem

Passwords dance, errors align,
With Rajini-style code design so fine! 💥
Validation strikes like lightning bold,
A form that's smart, precise, and controlled! 🔐
Error messages now whisper just right! 🌟

Possibly Related PRs

• test: Add tests for reset password page #3310: Adds tests for reset password page
• fix: fix spacing from top and other minor issues with UI #3313: Modifies button disabled state based on form validity
• fix: fix minor UI issues 2 #3317: Updates password field validation method

[Enters with a stylish swagger] Superstar style validation, boss! One small change, massive precision! 😎🔥 Error messages now dance exactly when they should - that's how we roll in code cinema! [Flips sunglasses]

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f30f660 and c0d2ff5.

📒 Files selected for processing (1)

• src/app/auth/new-password/new-password.page.html (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build (12.x)

🔇 Additional comments (1)

src/app/auth/new-password/new-password.page.html (1)

Line range hint 88-92: Mind it! The validation logic looks perfect, just like my signature style!

The additional condition !fg.controls.confirmPassword.errors.required is a superb move, macha! It prevents the confusion of showing two errors at once. When the field is empty, only "Password cannot be empty" shows up. When there's content but it doesn't match, then "Passwords do not match" makes its grand entry! 🕶️

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Unit Test Coverage	%	values
Statements	95.96%	( 19295 / 20106 )
Branches	91.11%	( 10660 / 11700 )
Functions	94.24%	( 5735 / 6085 )
Lines	96%	( 18421 / 19188 )