fix: Remove old personal card model - 1 (#3397)

[sumrender]

• fix: remove old getPersonalCardsCount method

• remove old getPersonalCards method

• replace use of PersonalCard model with PlatformPersonalCard

• fix: delete personal_card.model.ts and places where it was used (fix: delete personal_card.model.ts and places where it was used #3398)

• delete personal_card.model.ts and places where it was used

• fix: remove model PersonalCardTxnExpenseSuggestion (fix: remove model PersonalCardTxnExpenseSuggestion #3399)

• fix: remove model PersonalCardTxnExpenseSuggestion

• fix: transform personal card public queryParams to platform (fix: transform personal card public queryParams to platform #3400)

• fix: transform personal card public queryParams to platform

• fix: remove use of old PersonalCardTxn model (fix: remove use of old PersonalCardTxn model #3401)

• remove use of old PersonalCardTxn model

• delete public PersonalCardTxn model and corresponding ldFlag (fix: delete public PersonalCardTxn model and corresponding ldFlag #3402)

Clickup

https://app.clickup.com/t/86cwp3j66

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

Based on the comprehensive summary of changes, here are the release notes:

Release Notes

• Data Model Transition

  • Migrated from legacy personal card and transaction models to new platform-specific models
  • Introduced more structured and type-safe data representations

• Personal Card Transactions

  • Updated transaction details with new properties like description, amount, currency, and spent_at
  • Added support for transaction type classification (transactionType)

• Component and Service Updates

  • Simplified service methods by removing platform API conditional logic
  • Streamlined component inputs and data handling
  • Removed dependencies on external feature flag services

• User Interface

  • Minor adjustments to transaction and expense card displays
  • Improved data presentation with new transaction properties

• Testing

  • Updated test suites to align with new data models
  • Removed unnecessary service dependencies
  • Enhanced type safety in test configurations

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

In a spectacular transformation, the codebase has undergone a massive migration from legacy personal card models to platform-specific models. The changes span multiple files, replacing old interfaces like PersonalCard and PersonalCardTxn with new platform-oriented types. Key modifications include updating data structures, removing deprecated models, and refactoring service and component logic to work with the new PlatformPersonalCard and PlatformPersonalCardTxn types.

Changes

File Path	Change Summary
src/app/core/mock-data/...	Updated mock data to use platform-specific types and new data structures
src/app/core/models/...	Removed legacy models, added new platform-specific interfaces
src/app/fyle/...	Updated components and pages to use new transaction and card models
src/app/shared/components/...	Refactored components to work with platform-specific data types

Suggested Reviewers

• arjunaj5
• Chethan-Fyle

Possibly Related PRs

• fix: migrate personalCards:getLinkedAccounts to platform #3259: Modification of personal card query filter params
• fix: migrate delete personal card api to platform #3266: Migration of delete personal card API to platform
• fix: migrate list personal card transactions to platform #3279: Migration of personal card transactions to platform
• fix: migrate matchExpenses to platform #3288: Match expenses functionality migration
• fix: migrate personal card access token to platform #3292: Personal card access token handling migration
• fix: migrate sync/fetch personal cards txn to platform #3293: Sync/fetch transactions migration
• fix: migrate postAccounts personal card to platform #3294: PostAccounts functionality migration

Poem

Superstar style, code transformation divine! 🌟
Old models fade, platform models now shine! 💥
Interfaces dance, types take their stand
Rajinikanth's code - coolest in the land! 🚀
Migrations complete, with style so bright! 😎

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31d01b5 and daaa73c.

📒 Files selected for processing (35)

• src/app/core/mock-data/get-tasks-query-params-with-filters.data.ts (2 hunks)
• src/app/core/mock-data/personal-card-txn-expense-suggestions.data.ts (5 hunks)
• src/app/core/mock-data/personal-card-txns.data.ts (3 hunks)
• src/app/core/mock-data/personal-cards.data.ts (1 hunks)
• src/app/core/mock-data/unflattened-txn.data.ts (1 hunks)
• src/app/core/models/personal-card-txn-expense-suggestion.model.ts (0 hunks)
• src/app/core/models/personal_card.model.ts (0 hunks)
• src/app/core/models/personal_card_txn.model.ts (0 hunks)
• src/app/core/models/platform/platform-personal-card-filter-params.model.ts (1 hunks)
• src/app/core/models/platform/platform-personal-card-query-params.model.ts (1 hunks)
• src/app/core/models/platform/platform-personal-card-txn.model.ts (1 hunks)
• src/app/core/services/personal-cards.service.spec.ts (25 hunks)
• src/app/core/services/personal-cards.service.ts (13 hunks)
• src/app/fyle/add-edit-expense/add-edit-expense-3.spec.ts (2 hunks)
• src/app/fyle/add-edit-expense/add-edit-expense-4.spec.ts (11 hunks)
• src/app/fyle/add-edit-expense/add-edit-expense.page.ts (4 hunks)
• src/app/fyle/personal-cards-matched-expenses/expense-preview/expense-preview.component.spec.ts (1 hunks)
• src/app/fyle/personal-cards-matched-expenses/expense-preview/expense-preview.component.ts (3 hunks)
• src/app/fyle/personal-cards-matched-expenses/personal-cards-matched-expenses.page.html (1 hunks)
• src/app/fyle/personal-cards-matched-expenses/personal-cards-matched-expenses.page.spec.ts (6 hunks)
• src/app/fyle/personal-cards-matched-expenses/personal-cards-matched-expenses.page.ts (3 hunks)
• src/app/fyle/personal-cards/personal-cards.page.html (1 hunks)
• src/app/fyle/personal-cards/personal-cards.page.spec.ts (27 hunks)
• src/app/fyle/personal-cards/personal-cards.page.ts (25 hunks)
• src/app/shared/components/bank-account-cards/bank-account-card/bank-account-card.component.html (2 hunks)
• src/app/shared/components/bank-account-cards/bank-account-card/bank-account-card.component.spec.ts (5 hunks)
• src/app/shared/components/bank-account-cards/bank-account-card/bank-account-card.component.ts (5 hunks)
• src/app/shared/components/bank-account-cards/bank-account-cards.component.spec.ts (3 hunks)
• src/app/shared/components/bank-account-cards/bank-account-cards.component.ts (2 hunks)
• src/app/shared/components/expense-card-lite/expense-card-lite.component.html (1 hunks)
• src/app/shared/components/expense-card-lite/expense-card-lite.component.spec.ts (3 hunks)
• src/app/shared/components/expense-card-lite/expense-card-lite.component.ts (1 hunks)
• src/app/shared/components/personal-card-transaction/personal-card-transaction.component.html (2 hunks)
• src/app/shared/components/personal-card-transaction/personal-card-transaction.component.spec.ts (5 hunks)
• src/app/shared/components/personal-card-transaction/personal-card-transaction.component.ts (2 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Unit Test Coverage	%	values
Statements	95.96%	( 19289 / 20099 )
Branches	91.11%	( 10660 / 11700 )
Functions	94.26%	( 5734 / 6083 )
Lines	96%	( 18415 / 19181 )