fix: Revert "fix: revert verify/sign in changes (#3364)" #3371
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <color name="ic_launcher_new_splash_background">#FFFFFF</color> | ||
| </resources> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,33 @@ | ||
| <ion-content> | ||
| <div class="disabled-user"> | ||
| <div class="disabled-user__content-container"> | ||
| <div class="disabled-user__error-icon-container"> | ||
| <ion-icon | ||
| class="disabled-user__error-icon" | ||
| [src]="'/assets/svg/error-outlined.svg'" | ||
| slot="icon-only" | ||
| ></ion-icon> | ||
| </div> | ||
| <section class="disabled-user__text"> | ||
| <h1 class="disabled-user__header">Account disabled</h1> | ||
| <p class="disabled-user__content"> | ||
| This account is no longer active. Please contact your company admin for details. | ||
| </p> | ||
| </section> | ||
| </div> | ||
| <div class="disabled-user__cta"> | ||
| <ion-button | ||
| (click)="onGotoSignInClick()" | ||
| class="btn-primary" | ||
| fill="clear" | ||
| aria-label="Navigate back to sign in page" | ||
| role="button" | ||
| > | ||
| <div class="disabled-user__cta-content"> | ||
| <ion-icon class="disabled-user__arrow-icon" [src]="'/assets/svg/arrow-left.svg'" slot="icon-only"></ion-icon> | ||
| <span class="disabled-user__cta-text">Back to sign in</span> | ||
| </div> | ||
| </ion-button> | ||
| </div> | ||
| </div> | ||
| </ion-content> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,93 +1,80 @@ | ||
| @import '../../../theme/colors.scss'; | ||
|
|
||
| .disabled-user { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: space-between; | ||
| height: 100%; | ||
|
|
||
|
Comment on lines
+3
to
+7
There was a problem hiding this comment. 💡 Codebase verification Mind it! Your flex container needs some responsive style, macha! Listen here, style superstar! Your flex container is standing tall like a 100% height boss, but without proper responsive styles and overflow handling, it might create trouble on smaller screens. When the content becomes too much, it could overflow like a villain! To make it bulletproof:
Here's the style power-up you need: .disabled-user {
display: flex;
flex-direction: column;
justify-content: space-between;
height: 100%;
min-height: 400px; // Adjust based on your content
overflow-y: auto;
}🔗 Analysis chainAiyoo! This flex container is neat. Using flex with column direction and full height is a wise design choice. However, ensure that the container doesn’t force squashing in smaller screens. Would you like me to check usage for smaller breakpoints across your style files? 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
rg -A 5 --iglob '*.scss' 'disabled-user'
Length of output: 397 Script: #!/bin/bash
# Let's check for any media queries or responsive styles
rg -A 10 --iglob '*.scss' '@media.*\{' src/app/auth/disabled/
# Also check if there are any min-height declarations
rg --iglob '*.scss' 'min-height' src/app/auth/disabled/
# And look for any potential overflow handling
rg --iglob '*.scss' 'overflow' src/app/auth/disabled/
Length of output: 173 |
||
| &__content-container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| flex-grow: 2; | ||
| } | ||
|
|
||
| &__arrow-icon { | ||
| fill: $pure-white; | ||
| margin-right: 8px; | ||
| } | ||
|
|
||
| &__cta-text { | ||
| font-size: 14px; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| &__cta { | ||
| margin: 0 20px 24px 20px; | ||
| } | ||
|
|
||
| &__cta-content { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| &__error-icon-container { | ||
| width: 60px; | ||
| height: 60px; | ||
| border-radius: 8px; | ||
| background: $pale-pink; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| margin-bottom: 16px; | ||
| } | ||
|
Comment on lines
+37
to
+45
There was a problem hiding this comment. 🧹 Nitpick (assertive) Nalla idea! The error icon container styling is top-notch. Just be mindful of large error icons on small devices. The margin-bottom of 16px is good, but might you want to make the container responsive? |
||
|
|
||
| &__error-icon { | ||
| width: 45px; | ||
| height: 45px; | ||
| } | ||
|
|
||
| &__text { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 8px; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| &__header { | ||
| color: $black; | ||
| font-size: 20px; | ||
| font-style: normal; | ||
| font-weight: 500; | ||
| line-height: normal; | ||
| height: 26px; | ||
| margin: 0; | ||
| } | ||
|
|
||
| &__content { | ||
| color: $black-light; | ||
| text-align: center; | ||
| font-size: 14px; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| line-height: 1.25; | ||
| height: 36px; | ||
| width: 274px; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Enna config, Thalaiva?
This file is empty now. One day it might hold the secrets to your app’s destiny. Keep an eye on it, superstar!