Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert verify/sign in changes #3364

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Conversation

bistaastha
Copy link
Contributor

@bistaastha bistaastha commented Dec 17, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced password validation logic with stricter criteria for user accounts.
    • Introduced a streamlined layout for user account setup using Angular Material components.
    • Implemented a new component for sending verification emails, improving user experience during account verification.
  • Bug Fixes

    • Updated error handling and messaging for various user actions, including password resets and verification processes.
  • Style

    • Significant restructuring of styles for various components, focusing on modularity and improved visual hierarchy.
    • Removed redundant styles and classes, simplifying the CSS architecture.
  • Chores

    • Removed deprecated components related to password validation, streamlining the codebase.

Copy link

coderabbitai bot commented Dec 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

In a spectacular display of digital transformation, this pull request revolutionizes the authentication experience across multiple pages and components. The changes span from Android and iOS splash screens to comprehensive redesigns of sign-in, password reset, and verification flows. The primary focus is on enhancing user interface consistency, implementing more robust password validation, and streamlining the authentication user experience.

Changes

File/Group Change Summary
Android/iOS Resources Updated splash screen colors and launcher icons to a consistent dark purple theme (#220033)
Auth Pages Comprehensive UI/UX redesign for sign-in, reset password, new password, and verification pages
Styling Introduced new color variables, updated class naming conventions to BEM-like syntax
Components Removed password check tooltip, simplified form validation logic

Poem

Passwords dance, screens ignite bright,
Rajinikanth's code takes digital flight! 🔥
Authentication's stylish new design,
Where security and beauty intertwine! 💥
Boom! Verification done with swagger! 😎

Possibly Related PRs

Suggested Reviewers

  • Chethan-Fyle
  • arjunaj5

Sequence Diagram

sequenceDiagram
    participant User
    participant SignInPage
    participant AuthService
    participant VerificationPage

    User->>SignInPage: Enter Credentials
    SignInPage->>AuthService: Validate Credentials
    AuthService-->>SignInPage: Authentication Response
    alt Authentication Successful
        SignInPage->>VerificationPage: Navigate to Verification
        VerificationPage->>AuthService: Verify Identity
        AuthService-->>VerificationPage: Verification Status
    else Authentication Failed
        SignInPage->>SignInPage: Display Error Popover
    end
Loading

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb9cd69 and b38f333.

⛔ Files ignored due to path filters (19)
  • android/app/src/main/assets/splash-screen.png is excluded by !**/*.png
  • android/app/src/main/res/fyle_logo_square.png is excluded by !**/*.png
  • android/app/src/main/res/mipmap-hdpi/ic_launcher_new_splash.png is excluded by !**/*.png
  • android/app/src/main/res/mipmap-mdpi/ic_launcher_background.png is excluded by !**/*.png
  • android/app/src/main/res/mipmap-mdpi/ic_launcher_new_splash.png is excluded by !**/*.png
  • android/app/src/main/res/mipmap-xhdpi/ic_launcher_new_splash.png is excluded by !**/*.png
  • android/app/src/main/res/mipmap-xxhdpi/ic_launcher_new_splash.png is excluded by !**/*.png
  • android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_new_splash.png is excluded by !**/*.png
  • fyle_logo.png is excluded by !**/*.png
  • ios/App/App/Assets.xcassets/fyle_logo.png is excluded by !**/*.png
  • ios/App/App/fyle_logo.png is excluded by !**/*.png
  • ios/App/fyle_logo.png is excluded by !**/*.png
  • src/assets/svg/arrow-left.svg is excluded by !**/*.svg
  • src/assets/svg/check-circle-outline.svg is excluded by !**/*.svg
  • src/assets/svg/error-outlined.svg is excluded by !**/*.svg
  • src/assets/svg/eye-slash.svg is excluded by !**/*.svg
  • src/assets/svg/eye.svg is excluded by !**/*.svg
  • src/assets/svg/loader.svg is excluded by !**/*.svg
  • src/assets/videos/mobile-onboarding.mp4 is excluded by !**/*.mp4
📒 Files selected for processing (49)
  • android/app/src/main/res/drawable/ic_launcher_new_splash_foreground.xml (1 hunks)
  • android/app/src/main/res/values/ic_launcher_new_splash_background.xml (1 hunks)
  • android/app/src/main/res/values/styles.xml (1 hunks)
  • capacitor.config.json (0 hunks)
  • ios/App/App/Base.lproj/LaunchScreen.storyboard (1 hunks)
  • src/app/auth/disabled/disabled.page.html (1 hunks)
  • src/app/auth/disabled/disabled.page.scss (1 hunks)
  • src/app/auth/new-password/new-password.module.ts (0 hunks)
  • src/app/auth/new-password/new-password.page.html (1 hunks)
  • src/app/auth/new-password/new-password.page.scss (1 hunks)
  • src/app/auth/new-password/new-password.page.spec.ts (6 hunks)
  • src/app/auth/new-password/new-password.page.ts (3 hunks)
  • src/app/auth/pending-verification/pending-verification.page.html (1 hunks)
  • src/app/auth/pending-verification/pending-verification.page.scss (0 hunks)
  • src/app/auth/pending-verification/pending-verification.page.spec.ts (2 hunks)
  • src/app/auth/pending-verification/pending-verification.page.ts (1 hunks)
  • src/app/auth/reset-password/reset-password.page.html (1 hunks)
  • src/app/auth/reset-password/reset-password.page.scss (0 hunks)
  • src/app/auth/reset-password/reset-password.page.spec.ts (3 hunks)
  • src/app/auth/reset-password/reset-password.page.ts (1 hunks)
  • src/app/auth/sign-in/error/error.component.html (2 hunks)
  • src/app/auth/sign-in/error/error.component.scss (1 hunks)
  • src/app/auth/sign-in/error/error.component.spec.ts (5 hunks)
  • src/app/auth/sign-in/error/error.component.ts (1 hunks)
  • src/app/auth/sign-in/sign-in-page-state.enum.ts (0 hunks)
  • src/app/auth/sign-in/sign-in.page.html (1 hunks)
  • src/app/auth/sign-in/sign-in.page.scss (1 hunks)
  • src/app/auth/sign-in/sign-in.page.spec.ts (4 hunks)
  • src/app/auth/sign-in/sign-in.page.ts (3 hunks)
  • src/app/auth/verify/verify.page.html (1 hunks)
  • src/app/auth/verify/verify.page.scss (1 hunks)
  • src/app/auth/verify/verify.page.spec.ts (3 hunks)
  • src/app/auth/verify/verify.page.ts (3 hunks)
  • src/app/core/services/loader.service.spec.ts (1 hunks)
  • src/app/core/services/loader.service.ts (1 hunks)
  • src/app/post-verification/invited-user/invited-user.module.ts (0 hunks)
  • src/app/post-verification/invited-user/invited-user.page.html (1 hunks)
  • src/app/post-verification/invited-user/invited-user.page.scss (1 hunks)
  • src/app/post-verification/invited-user/invited-user.page.spec.ts (7 hunks)
  • src/app/post-verification/invited-user/invited-user.page.ts (3 hunks)
  • src/app/shared/components/password-check-tooltip/password-check-tooltip.component.html (0 hunks)
  • src/app/shared/components/password-check-tooltip/password-check-tooltip.component.scss (0 hunks)
  • src/app/shared/components/password-check-tooltip/password-check-tooltip.component.spec.ts (0 hunks)
  • src/app/shared/components/password-check-tooltip/password-check-tooltip.component.ts (0 hunks)
  • src/app/shared/components/password-check-tooltip/password-checks.model.ts (0 hunks)
  • src/app/shared/components/password-check-tooltip/password-criteria.model.ts (0 hunks)
  • src/app/shared/shared.module.ts (0 hunks)
  • src/global.scss (2 hunks)
  • src/theme/colors.scss (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/L Large PR label Dec 17, 2024
Copy link

Unit Test Coverage % values
Statements 96% ( 19243 / 20043 )
Branches 91.11% ( 10654 / 11693 )
Functions 94.36% ( 5742 / 6085 )
Lines 96.04% ( 18374 / 19130 )

@bistaastha bistaastha merged commit 160753f into master Dec 17, 2024
5 of 6 checks passed
bistaastha added a commit that referenced this pull request Dec 17, 2024
bistaastha added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants