Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing content corporate cards to my cards and manage cards #3345

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: changing content corporate cards to my cards and manage cards #3345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87d2e82
fix: changing content corporate cards to my cards and manage cards
Dec 12, 2024
eea3990
Merge branch 'master' into FYLE-86cxam1w4
Sishhhh Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/fyle/manage-corporate-cards/manage-corporate-cards.page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<mat-icon>keyboard_backspace</mat-icon>
</ion-button>
</ion-buttons>
<ion-title class="manage-corporate-cards__toolbar-title" mode="md">Manage Corporate Cards</ion-title>
<ion-title class="manage-corporate-cards__toolbar-title" mode="md">Manage cards</ion-title>
</ion-toolbar>
</ion-header>

Expand Down
4 changes: 2 additions & 2 deletions src/app/fyle/my-profile/my-profile.page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@
</div>

<ng-container *ngIf="isCCCEnabled && (isVisaRTFEnabled || isMastercardRTFEnabled || isVirtualCardsEnabled)">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Listen carefully! This needs some explanation, boss!

Consider adding a comment explaining why we need all these flags (isCCCEnabled, isVisaRTFEnabled, isMastercardRTFEnabled, isVirtualCardsEnabled) for conditional rendering. When the logic is complex, documentation is your best friend!

<div class="my-profile__section-header">Corporate Cards</div>
<div class="my-profile__section-header">My cards</div>
<div class="my-profile__card" [routerLink]="[ '/', 'enterprise', 'manage_corporate_cards' ]" matRipple>
<div class="my-profile__card__title">Manage Corporate Cards</div>
<div class="my-profile__card__title">Manage Cards</div>
<ion-icon
class="my-profile__navigate-icon"
src="../../../assets/svg/arrow-right.svg"
Expand Down
Loading