fix: remove unused code from my-expense and personal-card page

[sumrender]

Clickup

https://app.clickup.com/t/86cx44jq4

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

• Bug Fixes

  • Removed unnecessary setState methods from both MyExpensesPage and PersonalCardsPage, streamlining state management.

• Tests

  • Updated test suites by removing outdated test cases related to the setState method for both pages, ensuring focus on relevant functionalities.

[coderabbitai]

Walkthrough

The pull request brings notable changes to the MyExpensesPage and PersonalCardsPage components in an Angular application. The main modification is the removal of the setState method from both components, which previously handled loading states and pagination. Corresponding test cases for the setState method have also been eliminated from their respective test suites. While the overall structure of the components and tests remains intact, these changes indicate a simplification of state management within the components.

Changes

File Path	Change Summary
src/app/fyle/my-expenses/my-expenses.page.ts	Removed setState() method from MyExpensesPage, which managed loading state and pagination.
src/app/fyle/my-expenses/my-expenses.page.spec.ts	Removed test case for setState() method in MyExpensesPage test suite.
src/app/fyle/personal-cards/personal-cards.page.ts	Removed setState() method from PersonalCardsPage, which handled loading state and filter updates.
src/app/fyle/personal-cards/personal-cards.page.spec.ts	Removed test case for setState() method in PersonalCardsPage test suite.

Possibly related PRs

• fix: remove unmatch personal card feature #3265: The removal of the unmatchExpense method in the PersonalCardsService is related to the main PR's removal of the setState method in the MyExpensesPage, as both indicate a refactoring or removal of previously utilized functionalities in their respective components.
• fix: Bug in personal cards initialization #3272: The changes in the PersonalCardsPage component, particularly the removal of the ionViewWillEnter method, suggest a shift in how the component initializes its state, which aligns with the main PR's focus on simplifying state management by removing the setState method.
• fix:Change the header for multi-select of expense inside my-expense #3277: The modifications to the my-expenses.page.html and the associated changes in the UI reflect a broader effort to enhance user experience and manage state more effectively, similar to the main PR's removal of the setState method, which also aimed to simplify the component's logic.

Suggested labels

size/L

Suggested reviewers

• arjunaj5
• Chethan-Fyle
• hlkavya0213

🎉 In the world of code, changes take flight,
setState has vanished, oh what a sight!
With tests refined and logic so clear,
Simplifying the path, we have nothing to fear.
Angular shines bright, like a star in the night,
Onward we code, with all our might! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hlkavya0213]

make sure all references are removed

[github-actions]

Unit Test Coverage	%	values
Statements	96.02%	( 19193 / 19987 )
Branches	91.12%	( 10632 / 11668 )
Functions	94.4%	( 5733 / 6073 )
Lines	96.06%	( 18323 / 19073 )