feat: New polling logic for DE #3229

arjunaj5 · 2024-10-16T08:30:43Z

Clickup

https://app.clickup.com/t/86cwh9db4

Code Coverage

Please add code coverage here

UI Preview

Slack Thread containing recording

arjunaj5 · 2024-10-16T08:31:12Z

src/app/fyle/my-expenses/my-expenses.page.ts

+    // this is to prevent the scan failed from being shown from an indefinite amount of time.
+    const hasScanExpired = expense.created_at && dayjs(expense.created_at).diff(Date.now(), 'day') < 0;
+    return !!(hasUserManuallyEnteredData || isDataExtracted || hasScanExpired);
+  }


taken from expenses card component

arjunaj5 · 2024-10-16T08:32:19Z

src/app/fyle/my-expenses/my-expenses.page.ts

+  ): Observable<PlatformExpense[]> {
+    let updatedExpensesList = expenses;
+    // Create a stop signal that emits after 30 seconds
+    const stopPolling$ = timer(30000);


taking 30 seconds as the limit for polling after every 5 seconds.

arjunaj5 · 2024-10-16T08:34:01Z

src/app/shared/components/expenses-card-v2/expenses-card.component.ts

@@ -216,7 +216,7 @@ export class ExpensesCardComponent implements OnInit {
          (that.homeCurrency === 'USD' || that.homeCurrency === 'INR')
        ) {
          that.isScanCompleted = that.checkIfScanIsCompleted();
-          that.isScanInProgress = !that.isScanCompleted;
+          that.isScanInProgress = !that.isScanCompleted && !this.expense.extracted_data;


if isScanInProgress is false and isScanCompleted is also false, then the scan failed message is shown. This is the current behaviour.

should this be that.expense.extracted_data?

no, If extracted_data is present, then it means that the scan is completed.

mvaishnavi · 2024-10-21T16:16:37Z

src/app/shared/components/expenses-card/expenses-card.component.ts

@@ -208,7 +208,7 @@ export class ExpensesCardComponent implements OnInit {
          (that.homeCurrency === 'USD' || that.homeCurrency === 'INR')
        ) {
          that.isScanCompleted = that.checkIfScanIsCompleted();
-          that.isScanInProgress = !that.isScanCompleted;
+          that.isScanInProgress = !that.isScanCompleted && !this.expense.tx_extracted_data;


same as above.

* Fix failing tests * test: Add unit tests for DE polling (#3231) * Add unit tests for DE polling * minor * fix lint

github-actions · 2024-10-22T04:09:41Z

Unit Test Coverage	%	values
Statements	95.97%	( 19111 / 19913 )
Branches	91.21%	( 10564 / 11581 )
Functions	94.34%	( 5703 / 6045 )
Lines	96.01%	( 18241 / 18998 )

coderabbitai · 2024-10-24T07:15:51Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

New polling logic for DE

e87defd

arjunaj5 requested review from Chethan-Fyle and suyashpatil78 as code owners October 16, 2024 08:30

github-actions bot added the size/M Medium PR label Oct 16, 2024

arjunaj5 commented Oct 16, 2024

View reviewed changes

arjunaj5 requested a review from mvaishnavi October 16, 2024 08:34

Chethan-Fyle approved these changes Oct 17, 2024

View reviewed changes

mvaishnavi reviewed Oct 21, 2024

View reviewed changes

fix: remove dead test code, fix failing tests (#3230)

7ac5b42

* Fix failing tests * test: Add unit tests for DE polling (#3231) * Add unit tests for DE polling * minor * fix lint

github-actions bot added size/L Large PR and removed size/M Medium PR labels Oct 22, 2024

Add missing fields to the POST call (#3238)

a8c1c71

arjunaj5 added 4 commits October 24, 2024 13:17

remove unused imports

7f02621

fix failing test

f69f87a

fix linit

d1d1bc5

fix linit

4532ca7

arjunaj5 merged commit d233041 into Fyle-expenses-post-main Oct 24, 2024
4 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New polling logic for DE #3229

feat: New polling logic for DE #3229

arjunaj5 commented Oct 16, 2024 •

edited

Loading

arjunaj5 Oct 16, 2024

arjunaj5 Oct 16, 2024

arjunaj5 Oct 16, 2024

mvaishnavi Oct 21, 2024

arjunaj5 Oct 22, 2024

mvaishnavi Oct 21, 2024

github-actions bot commented Oct 22, 2024

coderabbitai bot commented Oct 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

feat: New polling logic for DE #3229

feat: New polling logic for DE #3229

Conversation

arjunaj5 commented Oct 16, 2024 • edited Loading

Clickup

Code Coverage

UI Preview

arjunaj5 Oct 16, 2024

Choose a reason for hiding this comment

arjunaj5 Oct 16, 2024

Choose a reason for hiding this comment

arjunaj5 Oct 16, 2024

Choose a reason for hiding this comment

mvaishnavi Oct 21, 2024

Choose a reason for hiding this comment

arjunaj5 Oct 22, 2024

Choose a reason for hiding this comment

mvaishnavi Oct 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 22, 2024

coderabbitai bot commented Oct 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

arjunaj5 commented Oct 16, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)