Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move v2/expenses from personal cards page to platform #3201

Merged
merged 15 commits into from
Sep 12, 2024

Conversation

bistaastha
Copy link
Contributor

No description provided.

Copy link
Contributor

@suyashpatil78 suyashpatil78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bistaastha one comment! Rest LGTM

@@ -75,7 +75,7 @@
</ion-col>
<ion-col size="7">
<div class="expense-preview--body-container__value">
{{ expenseDetails.tx_org_category }}
{{ expenseDetails.category.name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category?.name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If category is null

@bistaastha bistaastha marked this pull request as draft September 9, 2024 09:21
@bistaastha
Copy link
Contributor Author

Moved this to draft, will fix linting issues and unit tests and then set for review

@bistaastha bistaastha marked this pull request as ready for review September 10, 2024 06:07
@bistaastha bistaastha marked this pull request as draft September 10, 2024 12:12
@bistaastha bistaastha marked this pull request as ready for review September 10, 2024 17:02
Copy link

Unit Test Coverage % values
Statements 95.87% ( 19080 / 19901 )
Branches 91.19% ( 10465 / 11475 )
Functions 94.26% ( 5700 / 6047 )
Lines 95.9% ( 18210 / 18987 )

@bistaastha bistaastha merged commit a3a2080 into master Sep 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants