fix: Replace public implementation to display delegatee info with platform #3172
Conversation
harshal015
requested review from
Chethan-Fyle and
suyashpatil78
as code owners
| <div *ngIf="acc?.ou.org_id === currentOrg.id" class="delegated--org-element-us-details"> | ||
| {{currentOrg.name}} | ||
| </div> | ||
| <div class="delegated--org-element-us-details">{{currentOrg.name}}</div> |
There was a problem hiding this comment.
why have we removed the condition here? @harshal015
There was a problem hiding this comment.
it'll be anyway visible for all delegators as the API will respond with delegators from same org.
There was a problem hiding this comment.
can entirely remove the org name as well
| this.isDelegateePresent$ = from(this.authService.getEou()).pipe(map((eou) => eou.ou.delegatee_id !== null)); | ||
| this.isDelegateePresent$ = from(this.authService.getEou()).pipe( | ||
| switchMap((res) => this.employeesService.getByParams({ user_id: `eq.${res.us.id}` })), | ||
| map((employee) => employee.data.delegatees.length > 0) |
There was a problem hiding this comment.
If delegatees is null this would break right?
We have mentioned delegatees as optional in model and also as per docs.fylehq.com it could be null.
Use optional chaining.
| @@ -95,6 +103,7 @@ describe('NotificationsPage', () => { | |||
| }); | |||
|
|
|||
| orgUserSettingsService.get.and.returnValue(of(orgUserSettingsData)); | |||
| employeesService.getByParams.and.returnValue(of()); | |||
There was a problem hiding this comment.
Why are we not returning anything?
Either it should return employees or throw an error
| <div *ngIf="acc?.ou.org_id === currentOrg.id" class="delegated--org-element-us-details"> | ||
| {{currentOrg.name}} | ||
| </div> | ||
| <div class="delegated--org-element-name">{{acc?.full_name}}</div> |
There was a problem hiding this comment.
What happens if acc is undefined or null?
Are we handling the null cases as well?
There was a problem hiding this comment.
we are displaying switch accounts page only if its non empty, so it'll always have a value
|
* replace delegatee info from eou * minor * switch to delegator changes * fix unit tests * fix employee service unit tests * more fixes * switch to delegator changes * eslint fixes * more fixes * minor * add safety
Clickup
Please add link here
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes