fix: file location was incorrect of profile-opt-in-card #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
suyashpatil78
added a commit
that referenced
this pull request
Jun 25, 2024
* fix: SMS opt in design QA fix * test fix * minor * minor * minor * minor * fix: file location was incorrect of profile-opt-in-card (#3102) * minor
suyashpatil78
added a commit
that referenced
this pull request
Jun 26, 2024
… SMS Opt In (#3047) * feat: opt-in dialog as shared component (#3035) * feat: opt-in dialog as shared component * minor * minor * feat: opt-in dialog as shared component - Part 2 * feat: opt-in dialog as shared component - Part 3 * feat: opt-in dialog as shared component - Part 4 * test fix * minor * minor * minor * minor * minor * test: Opt in shared component tests - Part 1 (#3044) * feat: opt-in dialog as shared component * minor * minor * feat: opt-in dialog as shared component - Part 2 * feat: opt-in dialog as shared component - Part 3 * feat: opt-in dialog as shared component - Part 4 * test fix * minor * minor * minor * minor * test: Opt in shared component tests * minor * test: Opt in shared component tests - Part 1 * test: Opt in shared component tests - Part 2 (#3045) * test: Opt in shared component tests - Part 2 * test: Opt in shared component tests - Part 3 (#3046) * feat: task changes related to SMS Opt in (#3048) * feat: task changes related to SMS Opt in * test: unit test for task changes for opt in (#3049) * feat: added changes related to opt-in profile page changes (#3059) * feat: added changes related to opt-in profile page changes * test: fix tests in my-profile page and new presentational component (#3062) * test: fix tests in my-profile page and new presentational component * minor * feat: added opt out flow (#3063) * feat: show promotional modal after 2 second - Part 1 (#3071) * feat: show promotional modal after 2 second - Part 1 * minor * feat: added navigation condition in my expenses page (#3072) * feat: added navigation condition in my expenses page * feat: added opt-in modal in dashboard and manage CC (#3075) * feat: added opt-in promotional modal in dashboard and manage CC * test: covered test for opt-in guard (#3076) * test: covered test for opt-in guard * test: covered test for promote-opt-in-modal and manage card page (#3077) * test: covered test for promote-opt-in-modal and manage card page * test: covered test for my-expenses page (#3078) * test: covered test for my-expenses page * test: covered test for dashboard page (#3079) * test: covered test for dashboard page * minor template fix * test: covered test for utility service and feature config service (#3085) * test: covered test for utility service and feature config service * feat: added banner in dashboard (#3088) * feat: added banner in dashboard * minor template fix * test: test coverage of dashboard optin banner (#3090) * test: test coverage of dashboard optin banner * fix: minor UI/UX fixes for opt in (#3091) * fix: minor UI/UX fixes for opt in * minor * pr comments * pr comments * height of promote opt in modal * fix: major ui fix for opt-in promotional modal; (#3092) * fix: major ui fix for opt-in promotional modal; * test fix * redirection should not open modal again * fixing issues * fixing test * fixed UX issues * fix: refresh task after opting in * fix: SMS opt in design QA fix (#3100) * fix: SMS opt in design QA fix * test fix * minor * minor * minor * minor * fix: file location was incorrect of profile-opt-in-card (#3102) * minor
suyashpatil78
added a commit
that referenced
this pull request
Jun 26, 2024
… SMS Opt In (#3047) * feat: opt-in dialog as shared component (#3035) * feat: opt-in dialog as shared component * minor * minor * feat: opt-in dialog as shared component - Part 2 * feat: opt-in dialog as shared component - Part 3 * feat: opt-in dialog as shared component - Part 4 * test fix * minor * minor * minor * minor * minor * test: Opt in shared component tests - Part 1 (#3044) * feat: opt-in dialog as shared component * minor * minor * feat: opt-in dialog as shared component - Part 2 * feat: opt-in dialog as shared component - Part 3 * feat: opt-in dialog as shared component - Part 4 * test fix * minor * minor * minor * minor * test: Opt in shared component tests * minor * test: Opt in shared component tests - Part 1 * test: Opt in shared component tests - Part 2 (#3045) * test: Opt in shared component tests - Part 2 * test: Opt in shared component tests - Part 3 (#3046) * feat: task changes related to SMS Opt in (#3048) * feat: task changes related to SMS Opt in * test: unit test for task changes for opt in (#3049) * feat: added changes related to opt-in profile page changes (#3059) * feat: added changes related to opt-in profile page changes * test: fix tests in my-profile page and new presentational component (#3062) * test: fix tests in my-profile page and new presentational component * minor * feat: added opt out flow (#3063) * feat: show promotional modal after 2 second - Part 1 (#3071) * feat: show promotional modal after 2 second - Part 1 * minor * feat: added navigation condition in my expenses page (#3072) * feat: added navigation condition in my expenses page * feat: added opt-in modal in dashboard and manage CC (#3075) * feat: added opt-in promotional modal in dashboard and manage CC * test: covered test for opt-in guard (#3076) * test: covered test for opt-in guard * test: covered test for promote-opt-in-modal and manage card page (#3077) * test: covered test for promote-opt-in-modal and manage card page * test: covered test for my-expenses page (#3078) * test: covered test for my-expenses page * test: covered test for dashboard page (#3079) * test: covered test for dashboard page * minor template fix * test: covered test for utility service and feature config service (#3085) * test: covered test for utility service and feature config service * feat: added banner in dashboard (#3088) * feat: added banner in dashboard * minor template fix * test: test coverage of dashboard optin banner (#3090) * test: test coverage of dashboard optin banner * fix: minor UI/UX fixes for opt in (#3091) * fix: minor UI/UX fixes for opt in * minor * pr comments * pr comments * height of promote opt in modal * fix: major ui fix for opt-in promotional modal; (#3092) * fix: major ui fix for opt-in promotional modal; * test fix * redirection should not open modal again * fixing issues * fixing test * fixed UX issues * fix: refresh task after opting in * fix: SMS opt in design QA fix (#3100) * fix: SMS opt in design QA fix * test fix * minor * minor * minor * minor * fix: file location was incorrect of profile-opt-in-card (#3102) * minor
suyashpatil78
added a commit
that referenced
this pull request
Jun 28, 2024
… SMS Opt In (#3047) * feat: opt-in dialog as shared component (#3035) * feat: opt-in dialog as shared component * minor * minor * feat: opt-in dialog as shared component - Part 2 * feat: opt-in dialog as shared component - Part 3 * feat: opt-in dialog as shared component - Part 4 * test fix * minor * minor * minor * minor * minor * test: Opt in shared component tests - Part 1 (#3044) * feat: opt-in dialog as shared component * minor * minor * feat: opt-in dialog as shared component - Part 2 * feat: opt-in dialog as shared component - Part 3 * feat: opt-in dialog as shared component - Part 4 * test fix * minor * minor * minor * minor * test: Opt in shared component tests * minor * test: Opt in shared component tests - Part 1 * test: Opt in shared component tests - Part 2 (#3045) * test: Opt in shared component tests - Part 2 * test: Opt in shared component tests - Part 3 (#3046) * feat: task changes related to SMS Opt in (#3048) * feat: task changes related to SMS Opt in * test: unit test for task changes for opt in (#3049) * feat: added changes related to opt-in profile page changes (#3059) * feat: added changes related to opt-in profile page changes * test: fix tests in my-profile page and new presentational component (#3062) * test: fix tests in my-profile page and new presentational component * minor * feat: added opt out flow (#3063) * feat: show promotional modal after 2 second - Part 1 (#3071) * feat: show promotional modal after 2 second - Part 1 * minor * feat: added navigation condition in my expenses page (#3072) * feat: added navigation condition in my expenses page * feat: added opt-in modal in dashboard and manage CC (#3075) * feat: added opt-in promotional modal in dashboard and manage CC * test: covered test for opt-in guard (#3076) * test: covered test for opt-in guard * test: covered test for promote-opt-in-modal and manage card page (#3077) * test: covered test for promote-opt-in-modal and manage card page * test: covered test for my-expenses page (#3078) * test: covered test for my-expenses page * test: covered test for dashboard page (#3079) * test: covered test for dashboard page * minor template fix * test: covered test for utility service and feature config service (#3085) * test: covered test for utility service and feature config service * feat: added banner in dashboard (#3088) * feat: added banner in dashboard * minor template fix * test: test coverage of dashboard optin banner (#3090) * test: test coverage of dashboard optin banner * fix: minor UI/UX fixes for opt in (#3091) * fix: minor UI/UX fixes for opt in * minor * pr comments * pr comments * height of promote opt in modal * fix: major ui fix for opt-in promotional modal; (#3092) * fix: major ui fix for opt-in promotional modal; * test fix * redirection should not open modal again * fixing issues * fixing test * fixed UX issues * fix: refresh task after opting in * fix: SMS opt in design QA fix (#3100) * fix: SMS opt in design QA fix * test fix * minor * minor * minor * minor * fix: file location was incorrect of profile-opt-in-card (#3102) * minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
copilot:summary
copilot:poem
Walkthrough
copilot:walkthrough
Clickup
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes