Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fyle vapt 2024 tapjacking #2955

Closed
wants to merge 1 commit into from
Closed

Conversation

arjunaj5
Copy link
Contributor

@arjunaj5 arjunaj5 commented May 7, 2024

Description

copilot:summary

copilot:poem

Walkthrough

copilot:walkthrough

Clickup

https://app.clickup.com/t/86cv82hrm

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

@github-actions github-actions bot added the size/L Large PR label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

PR title must start with "fix:" or "feat:" or "test:"

Copy link

github-actions bot commented May 7, 2024

PR description must contain a link to a clickup

@arjunaj5 arjunaj5 changed the base branch from master to VAPT-fix May 8, 2024 05:05
Copy link

github-actions bot commented May 8, 2024

PR title must start with "fix:" or "feat:" or "test:"

Copy link

github-actions bot commented May 8, 2024

PR description must contain a link to a clickup

@arjunaj5 arjunaj5 marked this pull request as ready for review May 8, 2024 05:06
@arjunaj5 arjunaj5 requested a review from Chethan-Fyle as a code owner May 8, 2024 05:06
Copy link

ellipsis-dev bot commented May 8, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month. If you have any questions, reach us at [email protected]


// Prevent tapjacking attacks (vapt)
View rootView = getWindow().getDecorView().getRootView();
rootView.setFilterTouchesWhenObscured(true);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix as mentioned in the Appnox report

@arjunaj5 arjunaj5 requested a review from mvaishnavi May 8, 2024 05:19
@arjunaj5 arjunaj5 changed the title Fyle vapt 2024 tapjacking fix: Fyle vapt 2024 tapjacking May 8, 2024
Copy link

github-actions bot commented May 8, 2024

PR description must contain a link to a clickup

Copy link

github-actions bot commented May 8, 2024

Unit Test Coverage % values
Statements 96.03% ( 18548 / 19314 )
Branches 91.13% ( 9822 / 10777 )
Functions 94.28% ( 5597 / 5936 )
Lines 96.08% ( 17700 / 18422 )

@arjunaj5 arjunaj5 removed the request for review from Chethan-Fyle May 8, 2024 08:08
@arjunaj5 arjunaj5 closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants