feat: Add transformToV1Response & transformToV2Response for PlatformProject #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month. If you have any questions, reach us at [email protected] |
|
devendrafyle
approved these changes
May 3, 2024
suyashpatil78
approved these changes
May 3, 2024
Dimple16
approved these changes
May 3, 2024
Dimple16
added a commit
that referenced
this pull request
May 16, 2024
* Revert "fix: Improved test cases ProjectsService (#2980)" This reverts commit 77e6f4c. * Revert "feat: Migrate getByParamsUnformatted -> spenderPlatformV1ApiService (#2954)" This reverts commit 53f20fb. * Revert "feat: Migrate getAllActive -> spenderPlatformV1ApiService (#2967)" This reverts commit b5c9e2e. * Revert "feat: Migrate getbyId -> spenderPlatformV1ApiService (#2946)" This reverts commit e110648. * Revert "feat: Add transformToV1Response & transformToV2Response for PlatformProject (#2942)" This reverts commit 5ca606e. --------- Co-authored-by: Dimple <[email protected]>
Dimple16
added a commit
that referenced
this pull request
May 16, 2024
* Revert "fix: Improved test cases ProjectsService (#2980)" This reverts commit 77e6f4c. * Revert "feat: Migrate getByParamsUnformatted -> spenderPlatformV1ApiService (#2954)" This reverts commit 53f20fb. * Revert "feat: Migrate getAllActive -> spenderPlatformV1ApiService (#2967)" This reverts commit b5c9e2e. * Revert "feat: Migrate getbyId -> spenderPlatformV1ApiService (#2946)" This reverts commit e110648. * Revert "feat: Add transformToV1Response & transformToV2Response for PlatformProject (#2942)" This reverts commit 5ca606e. --------- Co-authored-by: Dimple <[email protected]>
SahilK-027
added a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the discussion in thread: https://fylein.slack.com/archives/C06M78V7JKD/p1713850203385719
Optional fields from
ProjectV2export interface ProjectV2 { - ap1_email?: string; - ap1_full_name?: string; - ap2_email?: string; - ap2_full_name?: string; - project_approver1_id?: string; - project_approver2_id?: string; }Clickup
Please add link here