Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace ExtendedProject -> ProjectV2 #2923

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

SahilK-027
Copy link
Contributor

@SahilK-027 SahilK-027 commented Apr 30, 2024

Description

While migrating ProjectsAPI to Platform we have noticed that we are using three models

  • More Specifically:
    • v1 - ProjectV1
    • v2 - ExtendedProject
    • platform - ProjectPlatform

The naming convention ExtendedProject looks incorrect. If we see the project service method, it uses /v2 API so the model name would be ProjectV2 .
So we have decided we will be renaming and replacing

ExtendedProject -> ProjectV2 . Across the entire mobile-app wherever we are using it.

- ExtendedProject
+ ProjectV2

Clickup

Please add link here

@SahilK-027 SahilK-027 self-assigned this Apr 30, 2024
Copy link

ellipsis-dev bot commented Apr 30, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at [email protected]

@github-actions github-actions bot added the size/M Medium PR label Apr 30, 2024
Copy link

PR title must start with "fix:" or "feat:" or "test:"

@SahilK-027 SahilK-027 changed the title Feat: Replace ExtendedProject -> ProjectV2 feat: Replace ExtendedProject -> ProjectV2 Apr 30, 2024
Copy link
Contributor

@Dimple16 Dimple16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

src/app/core/mock-data/recently-used.data.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 3, 2024

Unit Test Coverage % values
Statements 95.92% ( 18568 / 19357 )
Branches 91.11% ( 9822 / 10780 )
Functions 94.2% ( 5605 / 5950 )
Lines 95.96% ( 17720 / 18466 )

@SahilK-027 SahilK-027 merged commit 322061d into master May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants