Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to platform files api in view expense page #2920

Merged
merged 29 commits into from
May 27, 2024

Conversation

Chethan-Fyle
Copy link
Contributor

Description

copilot:summary

copilot:poem

Walkthrough

copilot:walkthrough

Clickup

https://app.clickup.com/t/86cv5kvqp

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Copy link

ellipsis-dev bot commented Apr 29, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at [email protected]

@github-actions github-actions bot added the size/M Medium PR label Apr 29, 2024
@Chethan-Fyle Chethan-Fyle changed the base branch from master to fyle-86cv5kvqp April 29, 2024 17:49
@Chethan-Fyle Chethan-Fyle changed the base branch from fyle-86cv5kvqp to fyle-86cv7bcfq April 29, 2024 17:49
@Chethan-Fyle Chethan-Fyle changed the base branch from fyle-86cv7bcfq to master April 30, 2024 16:52
@Chethan-Fyle Chethan-Fyle requested a review from suyashpatil78 May 6, 2024 06:51
Copy link
Contributor

@suyashpatil78 suyashpatil78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chethan-Fyle tests and eslint rules are failing. Can we please check this?

@Chethan-Fyle Chethan-Fyle requested a review from suyashpatil78 May 6, 2024 11:31
Copy link

Unit Test Coverage % values
Statements 96.13% ( 18578 / 19324 )
Branches 91.14% ( 9785 / 10736 )
Functions 94.55% ( 5588 / 5910 )
Lines 96.18% ( 17730 / 18434 )

@Chethan-Fyle Chethan-Fyle merged commit ed1fbbf into master May 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants