Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move report stats call to platform in dashboard #2907

Merged
merged 54 commits into from
May 7, 2024

Conversation

bistaastha
Copy link
Contributor

@bistaastha bistaastha commented Apr 29, 2024

Test coverage will be fixed in follow up

Copy link

PR description must contain a link to a clickup

@bistaastha bistaastha marked this pull request as ready for review April 29, 2024 10:31
Copy link

ellipsis-dev bot commented Apr 29, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at [email protected]

@bistaastha bistaastha requested a review from mvaishnavi April 29, 2024 11:01
@bistaastha bistaastha changed the title feat: Remove stats call from dashboard feat: Move report stats call to public in dashboard Apr 30, 2024
@mvaishnavi mvaishnavi changed the title feat: Move report stats call to public in dashboard feat: Move report stats call to platform in dashboard Apr 30, 2024
total_amount: 5012.12,
failed_amount: null,
failed_count: null,
processing_amount: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have processing_amount and processing_count, no?

Copy link
Contributor

@mvaishnavi mvaishnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

@bistaastha bistaastha changed the base branch from FYLE-86cuqn6db-add-methods-to-get-reports-approvers to master May 7, 2024 08:28
Copy link

github-actions bot commented May 7, 2024

Unit Test Coverage % values
Statements 95.91% ( 18606 / 19399 )
Branches 91.1% ( 9798 / 10755 )
Functions 94.16% ( 5616 / 5964 )
Lines 95.95% ( 17755 / 18504 )

@bistaastha bistaastha merged commit bd0ae68 into master May 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants