Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new interface PlatformProject + cleanup ExtendedProject unwanted fields #2903

Closed
wants to merge 6 commits into from

Conversation

SahilK-027
Copy link
Contributor

Description

as per the discussion in thread: https://fylein.slack.com/archives/C06M78V7JKD/p1713850203385719

  • Remove
- ap1_email: string;
- ap1_full_name: string;
- ap2_email: string;
- ap2_full_name: string;
- project_approver1_id: string;
- project_approver2_id: string;

Removed the above fields from ExtendedProjects

  • Created PlatformProject interface
  • Add transform method

Clickup

Please add link here

@SahilK-027 SahilK-027 self-assigned this Apr 26, 2024
Copy link

ellipsis-dev bot commented Apr 26, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at [email protected]

@github-actions github-actions bot added the size/M Medium PR label Apr 26, 2024
Copy link

PR title must start with "fix:" or "feat:" or "test:"

@SahilK-027 SahilK-027 changed the title Add new interface PlatformProject + cleanup ExtendedProject unwanted fields feat: Add new interface PlatformProject + cleanup ExtendedProject unwanted fields Apr 26, 2024
Copy link

Unit Test Coverage % values
Statements 96% ( 18575 / 19347 )
Branches 91.11% ( 9822 / 10780 )
Functions 94.43% ( 5605 / 5935 )
Lines 96.06% ( 17729 / 18456 )

@Dimple16 Dimple16 requested a review from suyashpatil78 April 29, 2024 10:05
Comment on lines -2 to -8
ap1_email: string;
ap1_full_name: string;
ap2_email: string;
ap2_full_name: string;
project_active: boolean;
project_approver1_id: string;
project_approver2_id: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check the usage of this modal, it should not break the previous code.

Copy link
Contributor Author

@SahilK-027 SahilK-027 Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are no longer using these keys.
You can checkout discussion regarding this here.
https://fylein.slack.com/archives/C06M78V7JKD/p1713870369981659?thread_ts=1713850203.385719&cid=C06M78V7JKD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this can we make these keys optional or can create a new modal for your use case, removing keys from the existing modal changes the previous model which is not correct imo because the previous modal was created about v2 APIs response that is still correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will confirm this once.

Copy link
Contributor

@devendrafyle devendrafyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@SahilK-027
Copy link
Contributor Author

There are multiple conflicts I will create a new separate PR for this.

@SahilK-027 SahilK-027 closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants