Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service methods for platform file api endpoints #2893

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

Chethan-Fyle
Copy link
Contributor

Description

copilot:summary

copilot:poem

Walkthrough

copilot:walkthrough

Clickup

https://app.clickup.com/t/86cv7bcfq

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Copy link

ellipsis-dev bot commented Apr 25, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at [email protected]

@github-actions github-actions bot added the size/S Small PR label Apr 25, 2024
@github-actions github-actions bot added size/M Medium PR and removed size/S Small PR labels Apr 29, 2024
Copy link
Contributor

@suyashpatil78 suyashpatil78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please to write unit tests for the spender/file and approver/file services in separate PRs

.pipe(map((response) => response.data));
}

downloadFile(id: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please specify the return type of the function.

.pipe(map((response) => response.data));
}

downloadFile(id: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return type is missing

Copy link

Unit Test Coverage % values
Statements 95.91% ( 18566 / 19356 )
Branches 91.11% ( 9822 / 10780 )
Functions 94.18% ( 5605 / 5951 )
Lines 95.95% ( 17720 / 18467 )

@Chethan-Fyle Chethan-Fyle merged commit 223d0e1 into master Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants