test: Add tests for Virtual Cards changes #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| spenderPlatformV1ApiService.get.and.returnValue(of(virtualCardUndefinedResponse)); | ||
|
|
||
| virtualCardsService.getVirtualCard(virtualCardsRequest).subscribe((res) => { | ||
| console.log(res); |
| }); | ||
|
|
||
| it('getCardDetailsInSerial(): should return serialised card details', () => { | ||
| const virtualCardsCombinedRequest: VirtualCardsCombinedRequest = { |
There was a problem hiding this comment.
declare this in separate virtual-cards-combined-request.data.ts file and import here
| [showAddCardSlide]="canAddCorporateCards$ | async" | ||
| (addCardClick)="openAddCorporateCardPopover()" | ||
| ></app-spent-cards> | ||
| <ng-container *ngIf="isVirtualCardsEnabled.enabled === true"> |
There was a problem hiding this comment.
Can we use <ng-container *ngIf="isVirtualCardsEnabled.enabled">
| @@ -187,6 +201,40 @@ describe('ManageCorporateCardsPage', () => { | |||
| expect(router.navigate).toHaveBeenCalledOnceWith(['/', 'enterprise', 'my_profile']); | |||
| }); | |||
|
|
|||
| describe('segmentChanged():', () => { | |||
| it('should show Virtual Card page', () => { | |||
| component.ionViewWillEnter(); | |||
There was a problem hiding this comment.
Why does this need to be called in test here?
| ); | ||
| }); | ||
|
|
||
| it('copyToClipboard(): should copy cvv on cvv copy icon tap', () => { |
There was a problem hiding this comment.
Add copyToClipboard tests together using describe block (another test is at line 44)
| component.ionViewWillEnter(); | ||
| component.virtualCardDetails$.subscribe((virtualCardDetailsRes) => { | ||
| expect(virtualCardDetailsRes).toBeDefined(); | ||
| console.log(virtualCardDetailsRes); |
|
|
||
| component.ionViewWillEnter(); | ||
| component.virtualCardDetails$.subscribe((virtualCardDetailsRes) => { | ||
| expect(virtualCardDetailsRes).toBeDefined(); |
There was a problem hiding this comment.
If it is defined what should be the value?
|
Some comments @bistaastha! Rest LGTM |
suyashpatil78
approved these changes
Feb 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
copilot:summary
copilot:poem
Walkthrough
copilot:walkthrough
Clickup
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes