test: removing unnecessary optionals and increasing branch cov - 4 #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmkarJ13
approved these changes
Oct 12, 2023
Julias0
approved these changes
Oct 16, 2023
suyashpatil78
added a commit
that referenced
this pull request
Oct 16, 2023
…2504) * test: removing unnecessary optionals and increasing branch cov - 2 * pr comments * test: removing unnecessary optionals and increasing branch cov - 3 (#2505) * test: removing unnecessary optionals and increasing branch cov - 3 * minor * minor * test: removing unnecessary optionals and increasing branch cov - 4 (#2506) * test: removing unnecessary optionals and increasing branch cov - 4 * minor
suyashpatil78
added a commit
that referenced
this pull request
Oct 16, 2023
…2503) * test: removing unnecessary optionals and increasing branch cov - 1 * pr comments * test: removing unnecessary optionals and increasing branch cov - 2 (#2504) * test: removing unnecessary optionals and increasing branch cov - 2 * pr comments * test: removing unnecessary optionals and increasing branch cov - 3 (#2505) * test: removing unnecessary optionals and increasing branch cov - 3 * minor * minor * test: removing unnecessary optionals and increasing branch cov - 4 (#2506) * test: removing unnecessary optionals and increasing branch cov - 4 * minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at d54a87a
This pull request improves the testing and code quality of the
MergeExpensesServiceclass, which handles the logic for merging expenses in the app. It adds and updates test cases for different methods and scenarios insrc/app/core/services/merge-expenses.service.spec.ts. It also removes unnecessary optional chaining operators from various properties insrc/app/core/services/merge-expenses.service.ts.🤖 Generated by Copilot at d54a87a
Walkthrough
🤖 Generated by Copilot at d54a87a
merge-expenses.service.ts(link, link, link, link, link)getCategoryName(),formatProjectOptions(),getCorporateCardTransactions(),getFieldValue(),getFieldValueOnChange(),formatTaxGroupOption(), andformatCategoryOption()methods inmerge-expenses.service.spec.ts(link, link, link, link, link, link, link)expectedOrgCategoryByName2fromorg-category.datafile inmerge-expenses.service.spec.ts(link)getCorporateCardTransactions()method inmerge-expenses.service.spec.ts(link)Clickup
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes