test: 100% coverage of virtual-select component #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmkarJ13
approved these changes
Oct 12, 2023
hlkavya0213
reviewed
Oct 12, 2023
| modalController.create.and.resolveTo(selectionModalSpy); | ||
| }); | ||
|
|
||
| it('openModal(): should open select modal and set value equals to value returned by modal', fakeAsync(() => { |
There was a problem hiding this comment.
if openModal(): is added in describe no need to add again inside the it, fix it for all
hlkavya0213
reviewed
Oct 12, 2023
| component.options = [ | ||
| { label: 'Business', value: 'BUSINESS' }, | ||
| { label: 'Economy', value: 'ECONOMY' }, | ||
| { label: '', value: '' }, |
There was a problem hiding this comment.
when do we get the label as empty string ?
hlkavya0213
reviewed
Oct 12, 2023
| spyOn(component, 'onChangeCallback'); | ||
| }); | ||
|
|
||
| it('should set the value and update the displayValue if any option.value is equal to innerValue', () => { |
There was a problem hiding this comment.
should set the value and update the displayValue if any "option.value" is equal to innerValue
hlkavya0213
reviewed
Oct 12, 2023
| expect(component.displayValue).toEqual(''); | ||
| //@ts-ignore | ||
| expect(component.onChangeCallback).toHaveBeenCalledOnceWith(''); | ||
| }); |
There was a problem hiding this comment.
one line space between each it()
hlkavya0213
reviewed
Oct 12, 2023
| //@ts-ignore | ||
| expect(component.onChangeCallback).toHaveBeenCalledOnceWith({ travelClass: 'BUSINESS', vendor: 'vendor1' }); | ||
| }); | ||
| it('should set the value and update the displayValue if none of the conditions holds true', () => { |
There was a problem hiding this comment.
same as above, fix it for all
hlkavya0213
reviewed
Oct 12, 2023
| ]; | ||
| }); | ||
|
|
||
| it('should set the value and update the displayValue if any option.value is equal to innerValue', () => { |
There was a problem hiding this comment.
should set the value and update the displayValue if any "option.value" is equal to innerValue
hlkavya0213
reviewed
Oct 12, 2023
| expect(component.innerValue).toEqual(''); | ||
| expect(component.displayValue).toEqual(''); | ||
| }); | ||
| it('should set the value and update the displayValue if innerValue and defaultLabelProps is defined', () => { |
suyashpatil78
commented
Oct 12, 2023
| @@ -162,6 +163,7 @@ describe('VirtualSelectModalComponent', () => { | |||
| //@ts-ignore | |||
| expect(component.onChangeCallback).toHaveBeenCalledOnceWith({ travelClass: 'BUSINESS', vendor: 'vendor1' }); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
added one line space, don't know why github not showing as resolved
Chethan-Fyle
approved these changes
Oct 13, 2023
hlkavya0213
approved these changes
Oct 13, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 56b2cf7
Added a shared component and unit tests for virtual select modal. The
VirtualSelectComponentallows users to select an option from a list using a modal, and integrates with theReactiveFormsModule. Thevirtual-select.component.spec.tsfile contains the unit tests for the component's methods and properties. Themodal-controller.data.tsfile provides mock data for creating the modal.🤖 Generated by Copilot at 56b2cf7
Walkthrough
🤖 Generated by Copilot at 56b2cf7
VirtualSelectModalComponentfor testingVirtualSelectComponent(link, link)ModalControllerservice (link)VirtualSelectComponent's creation, modal opening, value setting, validation, andControlValueAccessormethods (link)Clickup
Please add link here
Code Coverage
https://app.clickup.com/t/85zu3u05y
UI Preview
Please add screenshots for UI changes