feat: Removing Push Notifications in Settings #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julias0
reviewed
Oct 4, 2023
| @@ -31,7 +31,7 @@ <h2>Delegatee Notification</h2> | |||
| <ion-col> | |||
| <div><strong>{{ feature.value.textLabel }}</strong></div> | |||
| </ion-col> | |||
| <ion-col size="2" *ngIf="$first && (orgUserSettings$|async)?.notification_settings?.push.enabled"> | |||
| <ion-col size="2" *ngIf="$first && !(orgUserSettings$|async)?.notification_settings?.push.enabled"> | |||
There was a problem hiding this comment.
why dont we just remove the column?
Julias0
reviewed
Oct 4, 2023
| @@ -54,7 +54,7 @@ <h2>Delegatee Notification</h2> | |||
| <ion-col> | |||
| <div class="notifications--event-label">{{ event.textLabel }}</div> | |||
| </ion-col> | |||
| <ion-col size="2" *ngIf="(orgUserSettings$|async)?.notification_settings?.push.enabled"> | |||
| <ion-col size="2" *ngIf="!(orgUserSettings$|async)?.notification_settings?.push.enabled"> | |||
There was a problem hiding this comment.
why dont we just remove the column?
Julias0
approved these changes
Oct 4, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 1701f45
Fixed a bug in the notifications page that displayed checkboxes incorrectly. Updated the template logic in
notifications.page.htmlto respect thepushNotificationsEnabledflag.🤖 Generated by Copilot at 1701f45
Walkthrough
🤖 Generated by Copilot at 1701f45
Clickup
https://app.clickup.com/t/85ztx3ku4
Code Coverage
Please add code coverage here
UI Preview