feat: Mileage/ Per Diem expenses to depend on category #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR description must contain a link to a clickup |
1 similar comment
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
arjunaj5
changed the title
mvaishnavi
reviewed
Sep 28, 2023
| getMileageOrPerDiemCategories(): Observable<PlatformCategory[]> { | ||
| const data = { | ||
| params: { | ||
| is_enabled: 'eq.' + true, |
arjunaj5
commented
Sep 29, 2023
| @@ -29,6 +29,7 @@ import { expectedAssignedCCCStats } from '../../core/mock-data/ccc-expense.detai | |||
| import { of } from 'rxjs'; | |||
There was a problem hiding this comment.
will remove these unwanted changes
arjunaj5
commented
Sep 29, 2023
|
|
||
| describe('MyExpensesPage', () => { | ||
| fdescribe('MyExpensesPage', () => { |
Dimple16
approved these changes
Sep 29, 2023
| margin-right: 12px; | ||
| width: 24px; | ||
| height: 24px; | ||
| border-radius: 5px; |
|
@arjunaj5 please check if the tests are failing because of your changes? |
mvaishnavi
approved these changes
Oct 3, 2023
* coverage * test description update * fix tests * fix * more tests
|
arjunaj5
added a commit
that referenced
this pull request
Oct 4, 2023
* initial changes for dashboard * done * fix failing tests * pr comment fi * added categories service spy to tests * minor * remove unwanted changes * minor * remove fdescribe * test: Mileage/ Per Diem expenses to depend on category (#2468) * coverage * test description update * fix tests * fix * more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC section: https://www.notion.so/fyleuniverse/Application-Engineering-2b25fffe7b3641c3a5d90d4417a0e360?pvs=4#bb4e8bc013f140999e0937e99149c29d
https://app.clickup.com/t/85ztzt5y6
Description
🤖 Generated by Copilot at 1b53cfa
This pull request enables the creation of mileage and per diem expenses using special categories from the platform. It modifies the
dashboard.page.tsand thecategories.service.tsfiles to fetch and use these categories.🤖 Generated by Copilot at 1b53cfa
Walkthrough
🤖 Generated by Copilot at 1b53cfa
getMileageOrPerDiemCategoriesto fetch the special categories for mileage and per diem expenses (link)forkJoinoperator,PlatformCategorymodel, andCategoriesServiceindashboard.page.tsfile (link, link)specialCategories$to store the special categories observable (link)CategoriesServiceas a dependency in the constructor ofDashboardPageclass (link)orgSettings$andspecialCategories$observables usingforkJoinand passallowedExpenseTypesobject tosetupActionSheetmethod (link)setupActionSheetmethod to checkallowedExpenseTypesobject and display action sheet buttons accordingly (link)Clickup
Please add link here
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes