Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Image picker upgrade #2451

Closed
wants to merge 71 commits into from
Closed

feat: Image picker upgrade #2451

wants to merge 71 commits into from

Conversation

rupam-seal
Copy link
Contributor

@rupam-seal rupam-seal commented Sep 25, 2023

Description

🤖 Generated by Copilot at 3521a83

This pull request updates the Android app to use Java 17, Capacitor plugins, and the latest AndroidX libraries. It also fixes some linting and formatting issues, removes unused or deprecated code, and disables the Ionic Appflow live update feature.

🤖 Generated by Copilot at 3521a83

Sing, O Muse, of the mighty pull request
That updated the Android app with skill and zest
How the coder, wise in Gradle and Capacitor, changed the rules
And added new plugins, like Clipboard and Image Picker, as useful tools

Walkthrough

🤖 Generated by Copilot at 3521a83

  • Update ESLint rules and formatting for Angular, TypeScript and inline templates (link)
  • Upgrade Android Gradle plugin, Google Services plugin and Gradle wrapper to latest versions (link, link)
  • Change Java version from 11 to 17 for Android app compatibility and performance (link, link, link, link)
  • Set Android resource namespace for the app and remove redundant package attribute from manifest (link, link)
  • Update app version to 6.6.0 (link)
  • Add Smartlook SDK as a Maven dependency (link)
  • Add Capacitor Clipboard and Image Picker plugins and remove Cordova ImagePicker plugin (link, link, link, link, link, link, link, link, link, link)
  • Fix classpath value for Capacitor Secure Storage plugin (link)
  • Add ProGuard rules to keep Capacitor core and plugins classes (link)
  • Limit read external storage permission to Android 12 and lower and add read media images permission for Android 13 and higher (link)
  • Disable Ionic Appflow live update feature (link)
  • Update AndroidX library versions (link)
  • Use specific browser versions for web app output (link)
  • Delete unused run configurations file (link)

Clickup

https://app.clickup.com/t/85ztp0vrq

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

@rupam-seal rupam-seal changed the title Image picker upgrade feat: Image picker upgrade Sep 25, 2023
@github-actions github-actions bot added the size/XL Extra Large PR label Sep 25, 2023
@github-actions
Copy link

Unit Test Coverage % values
Statements 89.38% ( 15692 / 17556 )
Branches 89.25% ( 6032 / 6758 )
Functions 87.88% ( 4934 / 5614 )
Lines 89.57% ( 15206 / 16976 )

@rupam-seal rupam-seal closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Extra Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants