fix: Deprecate Physical Bills and related keys from the codebase (#2978)

* unit tests and services * models and dummy data files * eslint fixes * deprecate newly added keys
fylein · May 30, 2024 · ff42842 · ff42842
1 parent 1e5640c
commit ff42842
Show file tree

Hide file tree

Showing 36 changed files with 1 addition and 483 deletions.
diff --git a/src/app/core/mock-data/api-reports.data.ts b/src/app/core/mock-data/api-reports.data.ts
@@ -38,8 +38,6 @@ export const apiReportRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 0,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#5:  Jan 2023',
       rp_reimbursed_at: null,
@@ -97,8 +95,6 @@ export const apiReportRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 4,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: true,
       rp_purpose: '#4:  Jan 2023',
       rp_reimbursed_at: null,
@@ -156,8 +152,6 @@ export const apiReportRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#4:  Jan 2023',
       rp_reimbursed_at: null,
@@ -215,8 +209,6 @@ export const apiReportRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: true,
       rp_num_transactions: 3,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#24:  Dec 2022',
       rp_reimbursed_at: null,
@@ -282,8 +274,6 @@ export const apiReportSingleRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 3,
       rp_org_user_id: 'ouCI4UQ2G0K1',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: 'test_manage_columns',
       rp_reimbursed_at: null,
@@ -345,8 +335,6 @@ export const expectedReports: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 0,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#5:  Jan 2023',
       rp_reimbursed_at: null,
@@ -404,8 +392,6 @@ export const expectedReports: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 4,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: true,
       rp_purpose: '#4:  Jan 2023',
       rp_reimbursed_at: null,
@@ -463,8 +449,6 @@ export const expectedReports: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#4:  Jan 2023',
       rp_reimbursed_at: null,
@@ -522,8 +506,6 @@ export const expectedReports: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: true,
       rp_num_transactions: 3,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#24:  Dec 2022',
       rp_reimbursed_at: null,
@@ -584,8 +566,6 @@ export const apiAllReportsRes1: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 0,
       rp_org_user_id: 'ouCI4UQ2G0K1',
-      rp_physical_bill: true,
-      rp_physical_bill_at: new Date('2023-02-01T00:23:45.938Z'),
       rp_policy_flag: false,
       rp_purpose: '#4:  Feb 2023',
       rp_reimbursed_at: null,
@@ -637,8 +617,6 @@ export const apiAllReportsRes1: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouCI4UQ2G0K1',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#4:  Feb 2023',
       rp_reimbursed_at: null,
@@ -700,8 +678,6 @@ export const apiAllReportsRes2: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 0,
       rp_org_user_id: 'ouX8dwsbLCLv',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#5:  Jan 2023',
       rp_reimbursed_at: null,
@@ -771,8 +747,6 @@ export const apiTeamRptCountRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouWizR8UqaV9',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: 'New Dec Test',
       rp_reimbursed_at: null,
@@ -842,8 +816,6 @@ export const apiTeamRptSingleRes: ApiV2Response<ExtendedReport> = deepFreeze({
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouWizR8UqaV9',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: 'New Dec Test',
       rp_reimbursed_at: null,
@@ -913,8 +885,6 @@ export const apiTeamReportPaginated1: ApiV2Response<ExtendedReport> = deepFreeze
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouWizR8UqaV9',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: 'New Dec Test',
       rp_reimbursed_at: null,
@@ -971,8 +941,6 @@ export const apiTeamReportPaginated1: ApiV2Response<ExtendedReport> = deepFreeze
       rp_manual_flag: false,
       rp_num_transactions: 1,
       rp_org_user_id: 'ouWizR8UqaV9',
-      rp_physical_bill: false,
-      rp_physical_bill_at: null,
       rp_policy_flag: false,
       rp_purpose: '#2:  Dec 2022',
       rp_reimbursed_at: null,

diff --git a/src/app/core/mock-data/data-transform.data.ts b/src/app/core/mock-data/data-transform.data.ts
@@ -44,8 +44,6 @@ export const dataErtpTransformed = deepFreeze({
     manual_flag: false,
     num_transactions: 4,
     org_user_id: 'ouX8dwsbLCLv',
-    physical_bill: false,
-    physical_bill_at: null,
     policy_flag: false,
     purpose: 'My Testing Report',
     state: 'APPROVAL_PENDING',
@@ -110,8 +108,6 @@ export const apiErptReporDataParam = deepFreeze({
     manual_flag: false,
     num_transactions: 4,
     org_user_id: 'ouX8dwsbLCLv',
-    physical_bill: false,
-    physical_bill_at: null,
     policy_flag: false,
     purpose: 'My Testing Report',
     state: 'APPROVAL_PENDING',

diff --git a/src/app/core/mock-data/dependent-field-expenses.data.ts b/src/app/core/mock-data/dependent-field-expenses.data.ts
@@ -147,8 +147,6 @@ export const expensesWithDependentFields: Expense[] = deepFreeze([
     tx_orig_currency: null,
     tx_payment_id: 'payjBSZoHCy05',
     tx_per_diem_rate_id: null,
-    tx_physical_bill: false,
-    tx_physical_bill_at: null,
     tx_policy_amount: null,
     tx_policy_flag: false,
     tx_policy_state: null,
@@ -369,8 +367,6 @@ export const expensesWithDependentFields: Expense[] = deepFreeze([
     tx_orig_currency: null,
     tx_payment_id: 'payR8Q3X546o6',
     tx_per_diem_rate_id: null,
-    tx_physical_bill: false,
-    tx_physical_bill_at: null,
     tx_policy_amount: null,
     tx_policy_flag: false,
     tx_policy_state: null,
@@ -577,8 +573,6 @@ export const expensesWithSameProject: Expense[] = deepFreeze([
     tx_orig_currency: null,
     tx_payment_id: 'payjBSZoHCy05',
     tx_per_diem_rate_id: null,
-    tx_physical_bill: false,
-    tx_physical_bill_at: null,
     tx_policy_amount: null,
     tx_policy_flag: false,
     tx_policy_state: null,
@@ -795,8 +789,6 @@ export const expensesWithSameProject: Expense[] = deepFreeze([
     tx_orig_currency: null,
     tx_payment_id: 'payR8Q3X546o6',
     tx_per_diem_rate_id: null,
-    tx_physical_bill: false,
-    tx_physical_bill_at: null,
     tx_policy_amount: null,
     tx_policy_flag: false,
     tx_policy_state: null,

diff --git a/src/app/core/mock-data/expense-v2.data.ts b/src/app/core/mock-data/expense-v2.data.ts
@@ -129,8 +129,6 @@ export const expenseV2Data: ApiV2Response<Expense> = deepFreeze({
       tx_orig_currency: null,
       tx_payment_id: null,
       tx_per_diem_rate_id: null,
-      tx_physical_bill: false,
-      tx_physical_bill_at: null,
       tx_policy_amount: null,
       tx_policy_flag: false,
       tx_policy_state: null,
@@ -343,8 +341,6 @@ export const expenseV2DataMultiple: ApiV2Response<Expense> = deepFreeze({
       tx_orig_currency: null,
       tx_payment_id: 'pay43PWwwA2gV',
       tx_per_diem_rate_id: null,
-      tx_physical_bill: false,
-      tx_physical_bill_at: null,
       tx_policy_amount: null,
       tx_policy_flag: false,
       tx_policy_state: null,
@@ -548,8 +544,6 @@ export const expenseV2DataMultiple: ApiV2Response<Expense> = deepFreeze({
       tx_orig_currency: null,
       tx_payment_id: 'payPUt2DnqLZT',
       tx_per_diem_rate_id: null,
-      tx_physical_bill: false,
-      tx_physical_bill_at: null,
       tx_policy_amount: null,
       tx_policy_flag: false,
       tx_policy_state: null,