fix: split save button loader race condition (#2765)

src/app/fyle/split-expense/split-expense.page.ts

@@ -580,6 +580,7 @@ export class SplitExpensePage {
   }
 
   showSuccessToast(): void {
+    this.saveSplitExpenseLoading = false;
     const toastMessage = 'Expense split successfully.';
     if (this.reportId) {
       this.router.navigate(['/', 'enterprise', 'my_view_report', { id: this.reportId }]);
@@ -723,6 +724,8 @@ export class SplitExpensePage {
       .splitExpense(this.formattedSplitExpense, this.fileObjs, this.transaction, reportAndCategoryParams)
       .pipe(
         catchError((errResponse: HttpErrorResponse) => {
+          this.saveSplitExpenseLoading = false;
+
           const splitTrackingProps = this.getSplitExpensePoperties();
           splitTrackingProps['Error Message'] = (errResponse?.error as { message: string })?.message;
           this.trackingService.splitExpensePolicyCheckFailed(splitTrackingProps);
@@ -846,22 +849,25 @@ export class SplitExpensePage {
                 { reportId: this.reportId, unspecifiedCategory: this.unspecifiedCategory }
               );
 
+              this.saveSplitExpenseLoading = false;
+
               this.trackingService.splitExpensePolicyCheckFailed(splitTrackingProps);
 
               const message = 'We were unable to split your expense. Please try again later.';
               this.toastWithoutCTA(message, ToastType.FAILURE, 'msb-failure-with-camera-icon');
               return throwError(errResponse);
             }),
             finalize(() => {
-              this.saveSplitExpenseLoading = false;
-
               const splitTrackingProps = this.getSplitExpensePoperties();
               this.trackingService.splittingExpense(splitTrackingProps);
             })
           )
           .subscribe((response) => {
             if (response && response.action === 'continue') {
               this.handleSplitExpense(response.comments);
+            } else {
+              // If user clicks on cancel button, then stop the loader
+              this.saveSplitExpenseLoading = false;
             }
           });
       });