fix: added survey for add-edit-expense

src/app/core/services/refiner.service.spec.ts

@@ -54,44 +54,23 @@ describe('RefinerService', () => {
   });
 
   describe('getRegion', () => {
-    it('should return "India" for INR currency', () => {
-      expect(refinerService.getRegion('INR')).toEqual('India');
-    });
-
-    it('should return "International Americas" for USD', () => {
-      expect(refinerService.getRegion('USD')).toEqual('International Americas');
-    });
-
-    it('should return correct region for APAC currency', () => {
-      expect(refinerService.getRegion('AUD')).toEqual('International APAC');
-    });
-
-    it('should return correct region for Middle East Africa currency', () => {
-      expect(refinerService.getRegion('AED')).toEqual('International Africa');
-    });
-
-    it('should return correct region for Europe currency', () => {
-      expect(refinerService.getRegion('EUR')).toEqual('Europe');
-    });
-
-    it('should return "International Africa" for another Middle East Africa currency', () => {
-      expect(refinerService.getRegion('ZAR')).toEqual('International Africa');
-    });
-
-    it('should return "Undefined" for unsupported currency', () => {
-      expect(refinerService.getRegion('XYZ')).toEqual('Undefined');
-    });
-
-    it('should return "Undefined" for null currency', () => {
-      expect(refinerService.getRegion(null)).toEqual('Undefined');
-    });
-
-    it('should return "Undefined" for undefined currency', () => {
-      expect(refinerService.getRegion(undefined)).toEqual('Undefined');
-    });
-
-    it('should return "Undefined" for empty currency', () => {
-      expect(refinerService.getRegion('')).toEqual('Undefined');
+    const testCases = [
+      { currency: 'INR', expected: 'India' },
+      { currency: 'USD', expected: 'International Americas' },
+      { currency: 'AUD', expected: 'International APAC' },
+      { currency: 'AED', expected: 'International Africa' },
+      { currency: 'EUR', expected: 'Europe' },
+      { currency: 'ZAR', expected: 'International Africa' },
+      { currency: 'XYZ', expected: 'Undefined' },
+      { currency: null, expected: 'Undefined' },
+      { currency: undefined, expected: 'Undefined' },
+      { currency: '', expected: 'Undefined' },
+    ];
+
+    testCases.forEach(({ currency, expected }) => {
+      it(`should return "${expected}" for currency "${currency}"`, () => {
+        expect(refinerService.getRegion(currency)).toEqual(expected);
+      });
     });
   });
 

src/app/fyle/add-edit-expense/add-edit-expense.page.ts

@@ -138,6 +138,7 @@ import { corporateCardTransaction } from 'src/app/core/models/platform/v1/cc-tra
 import { PlatformFileGenerateUrlsResponse } from 'src/app/core/models/platform/platform-file-generate-urls-response.model';
 import { SpenderFileService } from 'src/app/core/services/platform/v1/spender/file.service';
 import { ExpenseTransactionStatus } from 'src/app/core/enums/platform/v1/expense-transaction-status.enum';
+import { RefinerService } from 'src/app/core/services/refiner.service';
 
 // eslint-disable-next-line
 type FormValue = {
@@ -487,6 +488,7 @@ export class AddEditExpensePage implements OnInit {
     private orgUserSettingsService: OrgUserSettingsService,
     private storageService: StorageService,
     private launchDarklyService: LaunchDarklyService,
+    private refinerService: RefinerService,
     private platformHandlerService: PlatformHandlerService,
     private expensesService: ExpensesService,
     private advanceWalletsService: AdvanceWalletsService
@@ -3591,6 +3593,22 @@ export class AddEditExpensePage implements OnInit {
     );
   }
 
+  triggerNpsSurvey(): void {
+    const roles$ = from(this.authService.getRoles().pipe(shareReplay(1)));
+    const showNpsSurvey$ = this.launchDarklyService.getVariation('nps_survey', false);
+
+    forkJoin([roles$, showNpsSurvey$])
+      .pipe(
+        switchMap(([roles, showNpsSurvey]) => {
+          if (showNpsSurvey && !roles.includes('ADMIN')) {
+            this.refinerService.startSurvey({ actionName: 'Save Expense' });
+          }
+          return of(null);
+        })
+      )
+      .subscribe();
+  }
+
   showSaveExpenseLoader(redirectedFrom: string): void {
     this.saveExpenseLoader = redirectedFrom === 'SAVE_EXPENSE';
     this.saveAndNewExpenseLoader = redirectedFrom === 'SAVE_AND_NEW_EXPENSE';
@@ -3603,6 +3621,8 @@ export class AddEditExpensePage implements OnInit {
     this.saveAndNewExpenseLoader = false;
     this.saveAndNextExpenseLoader = false;
     this.saveAndPrevExpenseLoader = false;
+
+    this.triggerNpsSurvey();
   }
 
   checkIfReceiptIsMissingAndMandatory(redirectedFrom: string): Observable<boolean> {
@@ -4555,13 +4575,6 @@ export class AddEditExpensePage implements OnInit {
       });
   }
 
-  private filterVendor(vendor: string): string | null {
-    if (!vendor || this.vendorOptions?.length === 0) {
-      return vendor;
-    }
-    return this.vendorOptions?.find((option) => option.toLowerCase() === vendor.toLowerCase()) || null;
-  }
-
   attachReceipts(data: { type: string; dataUrl: string | ArrayBuffer; actionSource?: string }): void {
     if (data) {
       const fileInfo = {
@@ -5234,4 +5247,11 @@ export class AddEditExpensePage implements OnInit {
 
     await popover.present();
   }
+
+  private filterVendor(vendor: string): string | null {
+    if (!vendor || this.vendorOptions?.length === 0) {
+      return vendor;
+    }
+    return this.vendorOptions?.find((option) => option.toLowerCase() === vendor.toLowerCase()) || null;
+  }
 }

src/app/fyle/add-edit-expense/add-edit-expense.setup.spec.ts

@@ -63,6 +63,7 @@ import { SpenderFileService } from 'src/app/core/services/platform/v1/spender/fi
 import { AdvanceWalletsService } from 'src/app/core/services/platform/v1/spender/advance-wallets.service';
 import { PAGINATION_SIZE } from 'src/app/constants';
 import { SpenderService } from 'src/app/core/services/platform/v1/spender/spender.service';
+import { HttpClientModule } from '@angular/common/http';
 
 export function setFormValid(component) {
   Object.defineProperty(component.fg, 'valid', {
@@ -230,7 +231,7 @@ describe('AddEditExpensePage', () => {
 
     TestBed.configureTestingModule({
       declarations: [AddEditExpensePage, MaskNumber, FySelectComponent, EllipsisPipe, DependentFieldComponent],
-      imports: [IonicModule.forRoot(), RouterTestingModule, RouterModule],
+      imports: [HttpClientModule, IonicModule.forRoot(), RouterTestingModule, RouterModule],
       providers: [
         FormBuilder,
         {

src/app/fyle/view-team-report/view-team-report.page.spec.ts

@@ -523,7 +523,7 @@ describe('ViewTeamReportPageV2', () => {
     });
 
     it('should handle comments when user is not present', () => {
-      component.eou$ = of(null); // Simulate no user
+      component.eou$ = of(null);
       component.setupComments({
         ...platformReportData,
         comments: [
@@ -536,7 +536,7 @@ describe('ViewTeamReportPageV2', () => {
           },
         ],
       });
-      expect(component.estatuses.length).toBe(1); // Check that it processes correctly
+      expect(component.estatuses.length).toBe(1);
     });
   });