fix: hide dashboard banner after opt in from card addition (#3129)

fylein · Jul 1, 2024 · 3d9ee43 · 3d9ee43
1 parent 14ccfd1
commit 3d9ee43
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/src/app/fyle/dashboard/dashboard.page.html b/src/app/fyle/dashboard/dashboard.page.html
@@ -61,7 +61,7 @@
       <app-card-stats (cardAdded)="onCardAdded()"></app-card-stats>
     </mat-tab>
     <mat-tab label="tasks">
-      <app-tasks></app-tasks>
+      <app-tasks (optedIn)="hideOptInDashboardBanner()"></app-tasks>
     </mat-tab>
   </mat-tab-group>
 </ion-content>

diff --git a/src/app/fyle/dashboard/dashboard.page.spec.ts b/src/app/fyle/dashboard/dashboard.page.spec.ts
@@ -807,4 +807,11 @@ describe('DashboardPage', () => {
       expect(component.tasksComponent.doRefresh).not.toHaveBeenCalled();
     });
   });
+
+  it('hideOptInDashboardBanner(): should set canShowOptInBanner$ to false', () => {
+    component.hideOptInDashboardBanner();
+    component.canShowOptInBanner$.subscribe((res) => {
+      expect(res).toBeFalse();
+    });
+  });
 });
diff --git a/src/app/fyle/dashboard/dashboard.page.ts b/src/app/fyle/dashboard/dashboard.page.ts
@@ -375,6 +375,7 @@ export class DashboardPage {
       } else {
         this.trackingService.optInFromPostPostCardAdditionInDashboard();
         this.tasksComponent.doRefresh();
+        this.canShowOptInBanner$ = of(false);
       }
     });
   }
@@ -438,4 +439,8 @@ export class DashboardPage {
       this.trackingService.skipOptInFromDashboardBanner();
     }
   }
+
+  hideOptInDashboardBanner(): void {
+    this.canShowOptInBanner$ = of(false);
+  }
 }
diff --git a/src/app/fyle/dashboard/tasks/tasks.component.ts b/src/app/fyle/dashboard/tasks/tasks.component.ts
@@ -1,4 +1,4 @@
-import { Component, EventEmitter, OnInit } from '@angular/core';
+import { Component, EventEmitter, OnInit, Output } from '@angular/core';
 import { MatBottomSheet } from '@angular/material/bottom-sheet';
 import { MatSnackBar } from '@angular/material/snack-bar';
 import { ActivatedRoute, Router } from '@angular/router';
@@ -44,6 +44,8 @@ import { TransactionStatus } from 'src/app/core/models/platform/v1/expense.model
   styleUrls: ['./tasks.component.scss'],
 })
 export class TasksComponent implements OnInit {
+  @Output() optedIn = new EventEmitter<void>();
+
   tasks$: Observable<DashboardTask[]>;
 
   loadData$: BehaviorSubject<TaskFilters> = new BehaviorSubject({
@@ -416,6 +418,7 @@ export class TasksComponent implements OnInit {
 
       if (data && data.action === 'SUCCESS') {
         this.doRefresh();
+        this.optedIn.emit();
       }
     });
   }