fix: Do not show pending transactions to add to report (#3122)

fylein · Jun 28, 2024 · 278a72e · 278a72e
1 parent 30c5ab6
commit 278a72e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/app/fyle/my-expenses/my-expenses.page.spec.ts b/src/app/fyle/my-expenses/my-expenses.page.spec.ts
@@ -308,6 +308,7 @@ describe('MyExpensesPage', () => {
       'getDeleteDialogBody',
       'restrictPendingTransactionsEnabled',
       'doesExpenseHavePendingCardTransaction',
+      'getReportableExpenses',
     ]);
     const utilityServiceSpy = jasmine.createSpyObj('UtilityService', [
       'canShowOptInAfterExpenseCreation',
@@ -2914,6 +2915,10 @@ describe('MyExpensesPage', () => {
         queryParams: { report_id: 'is.null', state: 'in.(COMPLETE,DRAFT)', q: 'Bus:*' },
       });
       expect(sharedExpenseService.excludeCCCExpenses).toHaveBeenCalledOnceWith(apiExpenses1);
+      expect(sharedExpenseService.getReportableExpenses).toHaveBeenCalledOnceWith(
+        component.selectedElements,
+        component.restrictPendingTransactionsEnabled
+      );
       expect(component.cccExpenses).toBe(0);
       expect(component.selectedElements).toEqual([...apiExpenses1]);
       expect(component.allExpensesCount).toBe(2);

diff --git a/src/app/fyle/my-expenses/my-expenses.page.ts b/src/app/fyle/my-expenses/my-expenses.page.ts
@@ -1626,7 +1626,10 @@ export class MyExpensesPage implements OnInit {
             }
             this.allExpensesCount = this.selectedElements.length;
             this.isReportableExpensesSelected =
-              this.sharedExpenseService.getReportableExpenses(this.selectedElements).length > 0;
+              this.sharedExpenseService.getReportableExpenses(
+                this.selectedElements,
+                this.restrictPendingTransactionsEnabled
+              ).length > 0;
             this.setExpenseStatsOnSelect();
           });
       }