Skip to content

Commit

Permalink
feat: Updating readme (#2491)
Browse files Browse the repository at this point in the history
* Updating readme

* minor
  • Loading branch information
suyashpatil78 authored Oct 5, 2023
1 parent ab028c1 commit 21c5025
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,19 @@ Please install node v14.17.2 or above via nvm.
- ionic serve -c `env_name`

# IMPORTANT
## before making any changes

- go to .git/hooks
- run in the shell - chmod +x pre-commit
- Note: It is to prevent keys from accidentally leaking.


## For setting environment variables

- Ping mobile app team for environment files
- Add them inside the environments folder
- Note: Do not make any changes to the environment.ts file - this is a template folder for creating configurations.
- Note: Do not make any changes to the environment.ts file - this is a template folder for creating configurations. Also, make sure not to put staging envs in this file.
- If you are getting errors like this:
```
Property 'LIVE_UPDATE_APP_VERSION' does not exist on type
'{ production: boolean; NAME: string; CLUSTER_DOMAIN: string; ROOT_URL: string; ROUTER_API_ENDPOINT: string;
ANDROID_CLIENT_ID: string; IP_FIND_KEY: string; GOOGLE_MAPS_API_KEY: string; FRESHCHAT_TOKEN: string;
SENTRY_DSN: string; REFINER_NPS_FORM_ID: string; }'
```
make sure you have the latest `environment.staging.ts` file.

## For creating pull requests

Expand Down

0 comments on commit 21c5025

Please sign in to comment.