feat: add qbd di flag #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
PR description must contain a link to a ClickUp (case-insensitive) |
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
reviewed
Oct 14, 2024
apps/orgs/serializers.py
Outdated
| @@ -49,7 +49,8 @@ def update(self, instance, validated): | |||
| else: | |||
| auth_tokens = AuthToken.objects.get(user__user_id=self.context['request'].user) | |||
| cluster_domain = get_cluster_domain(auth_tokens.refresh_token) | |||
| org = Org.objects.create(name=org_name, fyle_org_id=org_id, cluster_domain=cluster_domain) | |||
| allow_qbd_direct_integration = validated.get('allow_qbd_direct_integration', False) | |||
There was a problem hiding this comment.
why is this required when default is false?
There was a problem hiding this comment.
FE doesn't have to send it any time, we'll control everything in backend
There was a problem hiding this comment.
will we enable the flag from quickbooks_connector_api?
There was a problem hiding this comment.
no, via manual DB query from humans
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86cwmdjk2