Update and Create Employee on Webhook trigger from bamboohr #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ashwin1111
approved these changes
Jan 2, 2024
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ashwin1111
reviewed
Jan 2, 2024
|
|
||
| @receiver(post_save, sender=BambooHr) | ||
| def run_post_save_bamboohr_triggers(sender, instance: BambooHr, **kwargs): | ||
| bamboohrsdk = BambooHrSDK(api_token=instance.api_token, sub_domain=instance.sub_domain) |
There was a problem hiding this comment.
do all these only when webhook_id is null
apps/bamboohr/urls.py
Outdated
| @@ -1,11 +1,12 @@ | |||
| from django.urls import path | |||
|
|
|||
| from .views import PostFolder, PostPackage, BambooHrConnection, BambooHrView, BambooHrConfigurationView, \ | |||
| DisconnectView, SyncEmployeesView, HealthCheck | |||
| DisconnectView, SyncEmployeesView, HealthCheck, WebhookAPIView | |||
apps/bamboohr/signals.py
Outdated
| instance.webhook_id = int(response['id']) | ||
| instance.save() | ||
|
|
||
| @receiver(pre_delete, sender=BambooHr) |
There was a problem hiding this comment.
I don't think we delete bamboohr anywhere. This logic can be tied to the disconnect/ endpoint
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
|
ashwin1111
reviewed
Jan 3, 2024
apps/bamboohr/views.py
Outdated
| if isinstance(connection, Response): | ||
| return connection | ||
|
|
||
| webhook_id = request.data['webhook_id'] |
There was a problem hiding this comment.
read it from table since we have access for it, need not depend on client
apps/bamboohr/views.py
Outdated
| @@ -48,6 +48,24 @@ def get(self, request, *args, **kwargs): | |||
| status=status.HTTP_404_NOT_FOUND | |||
| ) | |||
|
|
|||
|
|
|||
| class WebhookAPIView(generics.CreateAPIView): | |||
There was a problem hiding this comment.
WebhookCallbackAPIView, match class name with url
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ashwin1111
approved these changes
Jan 3, 2024
Ashutosh619-sudo
added a commit
that referenced
this pull request
Jan 3, 2024
* API view added for refreshing employees from bamboohr * comment changes * minor change * bug fixed and minor changes * Update and Create Employee on Webhook trigger from bamboohr (#124) * Update Create Employee on Webhook trigger * tested and bug fix * create and delete webhook added * comment resolved * fixed and tested * minor changes * comment resolved * comment resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.