Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready View for making sure bamboohr Creds are valid #119

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

Ashutosh619-sudo
Copy link
Contributor

No description provided.

def get(self, request, *args, **kwargs):
try:
# bamboohr = BambooHr.objects.get(org_id__in=[kwargs['org_id']])
bamboohrsdk = BambooHrSDK(api_token='864acbfb14b38f974439af49ec95bc02e52a45b9', sub_domain='baba')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix this @Ashutosh619-sudo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are

data = {
'message': 'Invalid token'
},
status=status.HTTP_400_BAD_REQUEST
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

403 will be good here
cc @ashwin1111

Copy link

Tests Skipped Failures Errors Time
45 1 💤 1 ❌ 0 🔥 3.349s ⏱️

Copy link

Tests Skipped Failures Errors Time
45 1 💤 1 ❌ 0 🔥 2.810s ⏱️

logger = logging.getLogger(__name__)
logger.level = logging.INFO

class BambooHrReadyView(generics.ListAPIView):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change class name similar to url

Copy link

Tests Skipped Failures Errors Time
45 1 💤 1 ❌ 0 🔥 2.640s ⏱️

Copy link

Tests Skipped Failures Errors Time
45 1 💤 1 ❌ 0 🔥 2.641s ⏱️

@Ashutosh619-sudo Ashutosh619-sudo merged commit 2b10338 into master Dec 27, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants