-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready View for making sure bamboohr Creds are valid #119
Conversation
apps/bamboohr/views.py
Outdated
def get(self, request, *args, **kwargs): | ||
try: | ||
# bamboohr = BambooHr.objects.get(org_id__in=[kwargs['org_id']]) | ||
bamboohrsdk = BambooHrSDK(api_token='864acbfb14b38f974439af49ec95bc02e52a45b9', sub_domain='baba') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix this @Ashutosh619-sudo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are
data = { | ||
'message': 'Invalid token' | ||
}, | ||
status=status.HTTP_400_BAD_REQUEST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
403 will be good here
cc @ashwin1111
|
|
apps/bamboohr/views.py
Outdated
logger = logging.getLogger(__name__) | ||
logger.level = logging.INFO | ||
|
||
class BambooHrReadyView(generics.ListAPIView): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change class name similar to url
|
|
No description provided.