New employee exported at field added to Bamboohr table #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ashwin1111
approved these changes
Dec 26, 2023
fyle_employee_imports/base.py
Outdated
Comment on lines
128
to
129
| self.bamboohr.employee_exported_at = datetime.now() | ||
| self.bamboohr.save() |
There was a problem hiding this comment.
let's save only once after both of them are completed
There was a problem hiding this comment.
incase the 2nd call fails, we end up storing wrong timestamps
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.