Base class for importing employees between fyle and bamboohr #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Dec 20, 2023
fyle-employee_imports/base.py
Outdated
Comment on lines
8
to
9
| bamboohr = BambooHr.objects.get(org_id__in= org_id) | ||
| self.bamboohr_sdk = BambooHrSDK(api_token=bamboohr.api_token, sub_domain=bamboohr.sub_domain) |
There was a problem hiding this comment.
let's involve sdk only in the child class, base class shouldn't do anything app specific
fyle-employee_imports/base.py
Outdated
| pass | ||
|
|
||
| def sync_hrms_employees(self): | ||
| raise NotImplementedError('') |
There was a problem hiding this comment.
add a valid message, 'Implement sync_hrms_employees() in the child class'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 30 30
Lines 1031 1031
=======================================
Hits 974 974
Misses 57 57 |
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
* Implementaion of sync method for fyle and bamboohr * sync employees method added to platform connector * implementation of sync fyle and bamboo hr * removing api_token * indent correction * comment resolved * minor bug fix * better code * Import sync department (#115) * Syncing Department from Bamboohr to Fyle * resolved commented code * better optimized code * comment resolved * Employee and Approver Import (#116) * Employee and Approver Import * bug fix and comment resolved
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.