Merge branch 'bamboo_sdk_employee' into bamboo_sdk_main

fylein · Dec 20, 2023 · 6979dc2 · 6979dc2
2 parents 8267cc3 + e792302
commit 6979dc2
Show file tree

Hide file tree

Showing 2 changed files with 64 additions and 11 deletions.
diff --git a/bamboosdk/api/api_base.py b/bamboosdk/api/api_base.py
@@ -3,9 +3,6 @@
 import json
 from bamboosdk.exceptions import *
 
-
-payload = { "fields": ["displayName", "firstName", "lastName", "department", "workEmail", "supervisorEmail", "status"] }
-
 class ApiBase:
     """
     Base class for all API classes
@@ -17,7 +14,38 @@ def __init__(self) -> None:
         self.__sub_domain = None
         self.headers = None
 
-    def _post_request(self, module_api_path):
+    def _get_request(self, module_api_path):
+        """
+        HTTP get method get data from BambooHR API URL
+
+        Parameters:
+            module_api_path (str): URL of BambooHR API
+        """ 
+
+        url = self.API_BASE_URL.format(self.__sub_domain) + module_api_path
+        response = requests.get(url=url, headers=self.headers)
+        if response.status_code == 200:
+            result = json.loads(response.text)
+            return result
+
+        if response.status_code == 403:
+            error_msg = json.loads(response.text)
+            raise NoPrivilegeError('Forbidden, the user has insufficient privilege', error_msg)
+
+        if response.status_code == 404:
+            error_msg = json.loads(response.text)
+            raise NotFoundItemError('Not found item with ID', error_msg)
+
+        if response.status_code == 401:
+            error_msg = 'The api token is invalid'
+            raise InvalidTokenError('Invalid token, try to refresh it', error_msg)
+
+        else:
+            error_msg = json.loads(response.text)
+            raise BambooHrSDKError('Status code {0}'.format(response.status_code), error_msg)
+
+
+    def _post_request(self, module_api_path, payload):
         """
         HTTP post method to send data to BambooHR API URL
 
@@ -44,15 +72,39 @@ def _post_request(self, module_api_path):
             error_msg = 'The api token is invalid'
             raise InvalidTokenError('Invalid token, try to refresh it', error_msg)
 
-        if response.status_code == 500:
+        else:
+            error_msg = json.loads(response.text)
+            raise BambooHrSDKError('Status code {0}'.format(response.status_code), error_msg)
+
+    def _delete_request(self, module_api_path):
+        """
+        HTTP delete method to delete resource on BambooHR
+
+        Parameters:
+            module_api_path (str): URL of BambooHR API
+        """ 
+        url= self.API_BASE_URL.format(self.__sub_domain) + module_api_path
+        response = requests.delete(url=url, headers=self.headers)
+        if response.status_code == 200:
+            result = json.loads(response.text)
+            return result
+
+        if response.status_code == 403:
+            error_msg = json.loads(response.text)
+            raise NoPrivilegeError('Forbidden, the user has insufficient privilege', error_msg)
+
+        if response.status_code == 404:
             error_msg = json.loads(response.text)
-            raise InternalServerError('Internal server error', error_msg)
+            raise NotFoundItemError('Not found item with ID', error_msg)
 
-        raise BambooHrSDKError(
-            'Status code {0}'.format(response.status_code), response.text
-        )
+        if response.status_code == 401:
+            error_msg = 'The api token is invalid'
+            raise InvalidTokenError('Invalid token, try to refresh it', error_msg)
 
-
+        else:
+            error_msg = json.loads(response.text)
+            raise BambooHrSDKError('Status code {0}'.format(response.status_code), error_msg)
+
     def __encode_username_password(self):
         """
         Utility method to be used in the header for authorization

diff --git a/bamboosdk/api/employee.py b/bamboosdk/api/employee.py
@@ -4,10 +4,11 @@
 class Employee(ApiBase):
 
     GET_EMPLOYEE_REPORT = '/v1/reports/custom?format=JSON&onlyCurrent=false'
+    payload = { "fields": ["displayName", "firstName", "lastName", "department", "workEmail", "supervisorEmail", "status"] }
 
     def get_all(self):
         """Get the list of employees from bambooHr
         Returns:
             List with dicts in Employee schema.
         """
-        return self._post_request(self.GET_EMPLOYEE_REPORT)
+        return self._post_request(self.GET_EMPLOYEE_REPORT, payload=self.payload)