resolved comments

fylein · Dec 13, 2023 · 0427fac · 0427fac
1 parent e2e45dd
commit 0427fac
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/bamboosdk/api/api_base.py b/bamboosdk/api/api_base.py
@@ -44,9 +44,13 @@ def _post_request(self, module_api_path):
             error_msg = 'The api token is invalid'
             raise InvalidTokenError('Invalid token, try to refresh it', error_msg)
 
-        else:
-            error_msg = 'Something went wrong'
-            raise Exception('Something went wrong')
+        if response.status_code == 500:
+            error_msg = json.loads(response.text)
+            raise InternalServerError('Internal server error', error_msg)
+
+        raise BambooHrSDKError(
+            'Status code {0}'.format(response.status_code), response.text
+        )
 
 
     def __encode_username_password(self):

diff --git a/bamboosdk/exceptions.py b/bamboosdk/exceptions.py
@@ -25,3 +25,6 @@ class NotFoundItemError(BambooHrSDKError):
 
 class InvalidTokenError(BambooHrSDKError):
     """Invalid or non-existing access token, 401 error"""
+
+class InternalServerError(BambooHrSDKError):
+    """Internal server error, 500 error"""