Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic content for xero customize settings #1112

Merged
merged 3 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/app/branding/c1-contents-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,10 @@ export const c1Contents = {
accountingPeriodSubLabel: 'If the accounting period is closed, the expenses will be exported with a date stamp for the first day of the current open accounting period.',
autoCreateVendorsSubLabel: 'Automatically create a new contact in Xero if an added merchant doesn\'t have a corresponding match.',
customPreferencesLabel: 'Other preferences',
customPreferencesSubLabel: 'Create new records in Xero if no contacts found or the accounting period is closed.'
customPreferencesSubLabel: 'Create new records in Xero if no contacts found or the accounting period is closed.',
memoStructureLabel: 'Set the line-item description field in Xero',
memoStructureSubLabel: 'Choose from a list of available data points that you\'d like to export to the description field in Xero.',
customizeSectionSubLabel: 'Customize the data that you\'d like to export from Expense Management to Xero by choosing which data points need to be exported.'
}
}
},
Expand Down
1 change: 1 addition & 0 deletions src/app/branding/fyle-contents-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ export const fyleContents = {
topLevelMemoStructureSubLabel: 'Select the datapoints you\'d like to export to Xero’s top-level memo field when exporting expenses from Fyle.',
memoStructureLabel: 'Customize the Line-Item Level Memo Field',
memoStructureSubLabel: 'Select the datapoints you\'d like to export to Xero\’s line-item level memo field when exporting expenses from Fyle.',
customizeSectionSubLabel: 'In this section, you can customize the data that you\'d like to export from ' + brandingConfig.brandName + ' to Xero. You can choose what data points need to be exported and what shouldn\'t be.',
frequencySubLabel: 'Set a frequency based on how often you want your expenses in Fyle to be exported to Xero.',
customPreferencesLabel: 'Other Preferences',
customPreferencesSubLabel: 'Based on your preference, you can choose whether you want to create any new records in Xero from ' + brandingConfig.brandName + '. (when there is no employee record found, or when the accounting period is closed)',
Expand Down
3 changes: 3 additions & 0 deletions src/app/core/models/branding/content-configuration.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ export type ContentConfiguration = {
scheduleSubLabel: string;
accountingPeriodSubLabel: string;
autoCreateVendorsSubLabel: string;
memoStructureLabel: string;
memoStructureSubLabel: string;
customizeSectionSubLabel: string;
frequencySubLabel: string;
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,16 @@
<div class="tw-mb-16-px">
<app-configuration-step-sub-header
[label]="'Customization'"
[subLabel]="'In this section, you can customize the data that you\'d like to export from ' + brandingConfig.brandName + ' to Xero. You can choose what data points need to be exported and what shouldn\'t be.'">
[subLabel]="brandingContent.customizeSectionSubLAbel">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix typo in property name

There's a typo in the property name customizeSectionSubLAbel (capital 'A'). This should match the case used in the content configuration.

-    [subLabel]="brandingContent.customizeSectionSubLAbel">
+    [subLabel]="brandingContent.customizeSectionSubLabel">
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[subLabel]="brandingContent.customizeSectionSubLAbel">
[subLabel]="brandingContent.customizeSectionSubLabel">

</app-configuration-step-sub-header>
</div>
<div class="tw-rounded-12-px tw-border-separator tw-border tw-bg-white tw-mb-16-px">
<app-configuration-multi-select
[form]="advancedSettingForm"
[isFieldMandatory]="false"
[mandatoryErrorListName]="'Item level description'"
[label]="'Set the line item-level Description Field in Xero'"
[subLabel]="'You can choose from a list of available data points that you\'d like to export to the description field in Xero.'"
[label]="brandingContent.memoStructureLabel"
[subLabel]="brandingContent.memoStructureSubLabel"
[options]="defaultMemoFields"
[iconPath]="'list'"
[placeholder]="'Set description'"
Expand Down
Loading