Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QBD direct bug fixes #1101

Merged
merged 10 commits into from
Dec 10, 2024
Merged

fix: QBD direct bug fixes #1101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b8a9c0f
dummy commit
DhaaraniCIT Dec 10, 2024
1da613e
dashboard bug fix
DhaaraniCIT Dec 10, 2024
0bfe78e
dashboard bug fix
DhaaraniCIT Dec 10, 2024
522be3f
advanced settings bug fix
DhaaraniCIT Dec 10, 2024
287b3a3
QA fixes
DhaaraniCIT Dec 10, 2024
c25229f
QA fixes
DhaaraniCIT Dec 10, 2024
fed0d68
QA fixes
DhaaraniCIT Dec 10, 2024
1762b05
QA fixes
DhaaraniCIT Dec 10, 2024
3b7e2b5
QA fixes
DhaaraniCIT Dec 10, 2024
4acb11a
Merge branch 'master' into qbd-direct-testing-fixes-2
DhaaraniCIT Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
this.importSettingService.getImportSettings()
]).subscribe((responses) => {
this.errors = DashboardModel.parseAPIResponseToGroupedError(responses[0].results);
console.log(this.errors)

Check failure on line 143 in src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected console statement

Check failure on line 143 in src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.ts

View workflow job for this annotation

GitHub Actions / lint 

Missing semicolon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove debugging console.log statement

Production code should not contain console.log statements. If debugging is needed, consider using proper logging services or Angular's built-in logging mechanisms.

-      console.log(this.errors)
🧰 Tools
🪛 GitHub Check: lint

[failure] 143-143:
Unexpected console statement

[failure] 143-143:
Missing semicolon

🪛 eslint

[error] 143-143: Unexpected console statement.

(no-console)

[error] 143-144: Missing semicolon.

(semi)

this.isImportItemsEnabled = responses[3].import_items;
if (responses[1]) {
this.accountingExportSummary = AccountingExportSummaryModel.parseAPIResponseToAccountingSummaryForQbdDirect(responses[1]);
Expand Down
2 changes: 2 additions & 0 deletions .../shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@
this.errorArticle = accountingError.article_link;
// @ts-ignore
this.errorExpenses = accountingError[this.exportKey]?.expenses;
console.log(this.errorExpenses)

Check failure on line 185 in src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected console statement

Check failure on line 185 in src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts

View workflow job for this annotation

GitHub Actions / lint 

Missing semicolon

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove debugging console.log statement

Production code should not contain console.log statements. If error tracking is needed, consider using a proper logging service or Angular's error handling mechanisms.

-    console.log(this.errorExpenses)
-
🧰 Tools
🪛 GitHub Check: lint

[failure] 185-185:
Unexpected console statement

[failure] 185-185:
Missing semicolon

🪛 eslint

[error] 185-185: Unexpected console statement.

(no-console)

[error] 185-186: Missing semicolon.

(semi)

}

private formatErrors(errors: Error[]): AccountingGroupedErrors {
Expand Down
Loading