Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show a 'Beta' badge for business central in landing #1090

Conversation

JustARatherRidiculouslyLongUsername
Copy link
Contributor

@JustARatherRidiculouslyLongUsername JustARatherRidiculouslyLongUsername commented Nov 27, 2024

Clickup

https://app.clickup.com/t/86cx5t0wf

Summary by CodeRabbit

  • New Features

    • Enhanced layout and presentation of the accounting applications section on the landing page.
    • Added a conditional "Beta" badge for the "Dynamics 365 Business Central" application based on organization ID.
  • Bug Fixes

    • Improved visual spacing and alignment for better user experience.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Walkthrough

The changes involve updates to the landing.component.html and landing.component.ts files within the application. The HTML modifications enhance the layout of the accounting applications section, particularly for the "Dynamics 365 Business Central" application, by adding a class for better visual alignment and introducing a conditional "Beta" badge based on organization ID. The TypeScript file introduces a new readonly property for configuration without altering existing functionality.

Changes

File Path Change Summary
src/app/integrations/landing/landing.component.html Modified HTML structure to enhance layout; added class for spacing and conditional "Beta" badge.
src/app/integrations/landing/landing.component.ts Added new readonly property orgsToHideBusinessCentralBetaBadge initialized with an array of organization IDs.

Suggested reviewers

  • anishfyle

🐰 In the fields where bunnies play,
New changes hop in bright array.
A badge for "Beta," clear and neat,
With gaps and padding, oh so sweet!
Let's celebrate this joyful sight,
In code we trust, our future's bright! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d9d02aa and b97d089.

📒 Files selected for processing (1)
  • src/app/integrations/landing/landing.component.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/app/integrations/landing/landing.component.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/XS Extra Small PR label Nov 27, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
src/app/integrations/landing/landing.component.html (1)

76-76: Consider a more scalable feature flag implementation.

The current implementation using an array of organization IDs in the component might not scale well as the number of organizations grows. Consider implementing a more dynamic configuration approach:

  1. Move feature flags to a configuration service
  2. Use a backend API to manage feature flags
  3. Consider using a feature flag management system

This would make it easier to:

  • Update Beta access without code changes
  • Manage multiple feature flags consistently
  • Track feature flag usage
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 15005a7 and d9d02aa.

📒 Files selected for processing (2)
  • src/app/integrations/landing/landing.component.html (1 hunks)
  • src/app/integrations/landing/landing.component.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/app/integrations/landing/landing.component.ts
🔇 Additional comments (1)
src/app/integrations/landing/landing.component.html (1)

74-77: LGTM! The changes maintain consistency with existing patterns.

The implementation:

  1. Uses consistent styling classes for flex layout and spacing
  2. Follows the same Beta badge pattern as used for Sage 300 CRE
  3. Maintains visual consistency with other integration cards

@github-actions github-actions bot added size/S Small PR and removed size/XS Extra Small PR labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Unit Test Coverage % values
Statements 34.75% ( 4239 / 12196 )
Branches 28.55% ( 1222 / 4279 )
Functions 27.44% ( 938 / 3418 )
Lines 34.89% ( 4169 / 11946 )

@JustARatherRidiculouslyLongUsername JustARatherRidiculouslyLongUsername merged commit 2eac550 into business-central-beta Dec 3, 2024
5 checks passed
JustARatherRidiculouslyLongUsername added a commit that referenced this pull request Dec 3, 2024
* fix: remove export link column from export logs

* fix: show a 'Beta' badge for business central in landing (#1090)

* fix: show a 'Beta' badge for business central in landing

* fix: add orgs to hide the 'Beta' badge from

* fix: text changes in business central configuration (#1089)

* fix: export settings content changes

* fix: hide spend date help message for group by expenses

* fix: update import settings sublabels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants