-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show a 'Beta' badge for business central in landing #1090
fix: show a 'Beta' badge for business central in landing #1090
Conversation
WalkthroughThe changes involve updates to the Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/app/integrations/landing/landing.component.html (1)
76-76
: Consider a more scalable feature flag implementation.The current implementation using an array of organization IDs in the component might not scale well as the number of organizations grows. Consider implementing a more dynamic configuration approach:
- Move feature flags to a configuration service
- Use a backend API to manage feature flags
- Consider using a feature flag management system
This would make it easier to:
- Update Beta access without code changes
- Manage multiple feature flags consistently
- Track feature flag usage
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/app/integrations/landing/landing.component.html
(1 hunks)src/app/integrations/landing/landing.component.ts
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/app/integrations/landing/landing.component.ts
🔇 Additional comments (1)
src/app/integrations/landing/landing.component.html (1)
74-77
: LGTM! The changes maintain consistency with existing patterns.
The implementation:
- Uses consistent styling classes for flex layout and spacing
- Follows the same Beta badge pattern as used for Sage 300 CRE
- Maintains visual consistency with other integration cards
|
2eac550
into
business-central-beta
* fix: remove export link column from export logs * fix: show a 'Beta' badge for business central in landing (#1090) * fix: show a 'Beta' badge for business central in landing * fix: add orgs to hide the 'Beta' badge from * fix: text changes in business central configuration (#1089) * fix: export settings content changes * fix: hide spend date help message for group by expenses * fix: update import settings sublabels
Clickup
https://app.clickup.com/t/86cx5t0wf
Summary by CodeRabbit
New Features
Bug Fixes