Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: intacct advanced settings save functionality #1026

Merged
merged 4 commits into from
Oct 18, 2024
Merged

test: intacct advanced settings save functionality #1026

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a7a5fc
test: intacct advanced settings initialization
JustARatherRidiculouslyLongUsername Oct 15, 2024
5898fe2
test: intacct advanced settings watchers
JustARatherRidiculouslyLongUsername Oct 15, 2024
fbaadfe
test: intacct advanced settings save functionality
JustARatherRidiculouslyLongUsername Oct 15, 2024
a68d5d4
Merge branch 'master' into ut-intacct-advanced-settings-save
JustARatherRidiculouslyLongUsername Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 157 additions & 47 deletions ...acct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
import { FormBuilder, ReactiveFormsModule, Validators } from '@angular/forms';
import { provideRouter, Router } from '@angular/router';
import { of } from 'rxjs';
import { of, throwError } from 'rxjs';
import { IntacctAdvancedSettingsComponent } from './intacct-advanced-settings.component';
import { SiAdvancedSettingService } from 'src/app/core/services/si/si-configuration/si-advanced-setting.service';
import { IntegrationsToastService } from 'src/app/core/services/common/integrations-toast.service';
Expand All @@ -12,6 +12,8 @@ import { SkipExportComponent } from 'src/app/shared/components/si/helper/skip-ex
import { adminEmails, advancedSettings, configurationForAddvancedSettings, expenseFilter, groupedAttributes } from '../../intacct.fixture';
import { ExpenseFilterResponse } from 'src/app/core/models/intacct/intacct-configuration/advanced-settings.model';
import { SharedModule } from 'src/app/shared/shared.module';
import { IntacctOnboardingState, PaymentSyncDirection, ToastSeverity } from 'src/app/core/models/enum/enum.model';
import { SkipExport } from 'src/app/core/models/intacct/misc/skip-export.model';

describe('IntacctAdvancedSettingsComponent', () => {
let component: IntacctAdvancedSettingsComponent;
Expand All @@ -25,14 +27,20 @@ describe('IntacctAdvancedSettingsComponent', () => {


beforeEach(async () => {
const advancedSettingsServiceSpy = jasmine.createSpyObj('SiAdvancedSettingService', ['getAdvancedSettings', 'getExpenseFilter', 'getAdditionalEmails']);
const advancedSettingsServiceSpy = jasmine.createSpyObj('SiAdvancedSettingService', [
'getAdvancedSettings',
'getExpenseFilter',
'getAdditionalEmails',
'postAdvancedSettings',
'deleteExpenseFilter'
]);
JustARatherRidiculouslyLongUsername marked this conversation as resolved.
Show resolved Hide resolved
const toastServiceSpy = jasmine.createSpyObj('IntegrationsToastService', ['displayToastMessage']);
const trackingServiceSpy = jasmine.createSpyObj('TrackingService', ['trackTimeSpent', 'integrationsOnboardingCompletion', 'intacctUpdateEvent']);
const workspaceServiceSpy = jasmine.createSpyObj('SiWorkspaceService', ['getIntacctOnboardingState', 'setIntacctOnboardingState']);
const mappingServiceSpy = jasmine.createSpyObj('SiMappingsService', ['getGroupedDestinationAttributes', 'getConfiguration', 'refreshSageIntacctDimensions', 'refreshFyleDimensions']);
await TestBed.configureTestingModule({
declarations: [ IntacctAdvancedSettingsComponent, SkipExportComponent ],
imports: [ SharedModule, ReactiveFormsModule ],
declarations: [IntacctAdvancedSettingsComponent, SkipExportComponent],
imports: [SharedModule, ReactiveFormsModule],
providers: [
FormBuilder,
{ provide: SiAdvancedSettingService, useValue: advancedSettingsServiceSpy },
Expand All @@ -50,6 +58,7 @@ describe('IntacctAdvancedSettingsComponent', () => {
workspaceService = TestBed.inject(SiWorkspaceService) as jasmine.SpyObj<SiWorkspaceService>;
mappingService = TestBed.inject(SiMappingsService) as jasmine.SpyObj<SiMappingsService>;
router = TestBed.inject(Router);
spyOn(router, 'navigate');

advancedSettingsService.getAdditionalEmails.and.returnValue(of(adminEmails));
advancedSettingsService.getAdvancedSettings.and.returnValue(of(advancedSettings));
Expand All @@ -65,55 +74,156 @@ describe('IntacctAdvancedSettingsComponent', () => {
expect(component).toBeTruthy();
});

it('should initialize with correct data', fakeAsync(() => {
fixture.detectChanges();
tick();

expect(component.isLoading).toBeFalse();
expect(component.adminEmails).toEqual(adminEmails.concat(advancedSettings.workspace_schedules.additional_email_options));
expect(component.advancedSettings).toEqual(advancedSettings);
expect(component.sageIntacctLocations).toEqual(groupedAttributes.LOCATION);
expect(component.sageIntacctDefaultItem).toEqual(groupedAttributes.ITEM);
expect(component.sageIntacctDepartments).toEqual(groupedAttributes.DEPARTMENT);
expect(component.sageIntacctProjects).toEqual(groupedAttributes.PROJECT);
expect(component.sageIntacctClasses).toEqual(groupedAttributes.CLASS);
expect(component.sageIntacctPaymentAccount).toEqual(groupedAttributes.PAYMENT_ACCOUNT);
expect(component.reimbursableExpense).toEqual(configurationForAddvancedSettings.reimbursable_expenses_object);
expect(component.corporateCreditCardExpense).toEqual(configurationForAddvancedSettings.corporate_credit_card_expenses_object);
expect(component.importVendorsAsMerchants).toEqual(configurationForAddvancedSettings.import_vendors_as_merchants);
expect(component.useMerchantInJournalLine).toEqual(configurationForAddvancedSettings.use_merchant_in_journal_line);
expect(component.employeeFieldMapping).toEqual(configurationForAddvancedSettings.employee_field_mapping);
}));

it('should initialize forms correctly', () => {
fixture.detectChanges();

expect(component.advancedSettingsForm).toBeDefined();
expect(component.skipExportForm).toBeDefined();

expect(component.advancedSettingsForm.get('exportSchedule')?.value).toBeTrue();
expect(component.advancedSettingsForm.get('exportScheduleFrequency')?.value).toBe(12);
expect(component.advancedSettingsForm.get('setDescriptionField')?.value).toEqual(['employee_email', 'merchant', 'purpose']);
describe('Initialization', () => {
it('should initialize with correct data', fakeAsync(() => {
fixture.detectChanges();
tick();

expect(component.isLoading).toBeFalse();
expect(component.adminEmails).toEqual(adminEmails.concat(advancedSettings.workspace_schedules.additional_email_options));
expect(component.advancedSettings).toEqual(advancedSettings);
expect(component.sageIntacctLocations).toEqual(groupedAttributes.LOCATION);
expect(component.sageIntacctDefaultItem).toEqual(groupedAttributes.ITEM);
expect(component.sageIntacctDepartments).toEqual(groupedAttributes.DEPARTMENT);
expect(component.sageIntacctProjects).toEqual(groupedAttributes.PROJECT);
expect(component.sageIntacctClasses).toEqual(groupedAttributes.CLASS);
expect(component.sageIntacctPaymentAccount).toEqual(groupedAttributes.PAYMENT_ACCOUNT);
expect(component.reimbursableExpense).toEqual(configurationForAddvancedSettings.reimbursable_expenses_object);
expect(component.corporateCreditCardExpense).toEqual(configurationForAddvancedSettings.corporate_credit_card_expenses_object);
expect(component.importVendorsAsMerchants).toEqual(configurationForAddvancedSettings.import_vendors_as_merchants);
expect(component.useMerchantInJournalLine).toEqual(configurationForAddvancedSettings.use_merchant_in_journal_line);
expect(component.employeeFieldMapping).toEqual(configurationForAddvancedSettings.employee_field_mapping);
}));

it('should initialize forms correctly', () => {
fixture.detectChanges();

expect(component.advancedSettingsForm).toBeDefined();
expect(component.skipExportForm).toBeDefined();

expect(component.advancedSettingsForm.get('exportSchedule')?.value).toBeTrue();
expect(component.advancedSettingsForm.get('exportScheduleFrequency')?.value).toBe(12);
expect(component.advancedSettingsForm.get('setDescriptionField')?.value).toEqual(['employee_email', 'merchant', 'purpose']);
});

it('should handle onboarding state correctly', () => {
spyOnProperty(router, 'url').and.returnValue('/integrations/intacct/onboarding/advanced_settings');
fixture.detectChanges();

expect(component.isOnboarding).toBeTrue();
});

it('should handle non-onboarding state correctly', () => {
spyOnProperty(router, 'url').and.returnValue('/integrations/intacct/advanced_settings');
fixture.detectChanges();

expect(component.isOnboarding).toBeFalse();
});

it('should create memo preview correctly', () => {
fixture.detectChanges();

const expectedPreview = '[email protected] - Pizza Hut - Client Meeting';
expect(component.memoPreviewText).toBe(expectedPreview);
});
});

it('should handle onboarding state correctly', () => {
spyOnProperty(router, 'url').and.returnValue('/integrations/intacct/onboarding/advanced_settings');
fixture.detectChanges();
describe('Watchers', () => {
beforeEach(() => {
fixture.detectChanges();
});

expect(component.isOnboarding).toBeTrue();
});
it('should update memo preview when setDescriptionField changes', fakeAsync(() => {
const newMemoStructure = ['category', 'purpose', 'spent_on'];
component.advancedSettingsForm.get('setDescriptionField')?.setValue(newMemoStructure);
tick();

it('should handle non-onboarding state correctly', () => {
spyOnProperty(router, 'url').and.returnValue('/integrations/intacct/advanced_settings');
fixture.detectChanges();
expect(component.memoStructure).toEqual(newMemoStructure);
expect(component.memoPreviewText).toBe('Client Meeting - Meals and Entertainment - ' + new Date(Date.now()).toLocaleDateString());
JustARatherRidiculouslyLongUsername marked this conversation as resolved.
Show resolved Hide resolved
}));

expect(component.isOnboarding).toBeFalse();
});
it('should update defaultPaymentAccount validators when autoSyncPayments changes', fakeAsync(() => {
component.advancedSettingsForm.get('autoSyncPayments')?.setValue(PaymentSyncDirection.FYLE_TO_INTACCT);
tick();

expect(component.advancedSettingsForm.get('defaultPaymentAccount')?.hasValidator(Validators.required)).toBeTrue();

it('should create memo preview correctly', () => {
fixture.detectChanges();
component.advancedSettingsForm.get('autoSyncPayments')?.setValue(null);
tick();

expect(component.advancedSettingsForm.get('defaultPaymentAccount')?.hasValidator(Validators.required)).toBeFalse();
}));
});

const expectedPreview = '[email protected] - Pizza Hut - Client Meeting';
expect(component.memoPreviewText).toBe(expectedPreview);
describe('Save', () => {
beforeEach(fakeAsync(() => {
fixture.detectChanges();
advancedSettingsService.deleteExpenseFilter.and.returnValue(of({} as SkipExport));
}));

it('should handle save advanced settings during onboarding', fakeAsync(() => {
const mockResponse = { ...advancedSettings };
advancedSettingsService.postAdvancedSettings.and.returnValue(of(mockResponse));
workspaceService.getIntacctOnboardingState.and.returnValue(IntacctOnboardingState.ADVANCED_CONFIGURATION);

component.skipExportChild = { saveSkipExportFields: jasmine.createSpy('saveSkipExportFields') } as any;
component.advancedSettingsForm.get('skipSelectiveExpenses')?.setValue(true);
component.isOnboarding = true;

component.save();
tick();

expect(advancedSettingsService.postAdvancedSettings).toHaveBeenCalled();
expect(component.skipExportChild.saveSkipExportFields).toHaveBeenCalled();
expect(toastService.displayToastMessage).toHaveBeenCalledWith(ToastSeverity.SUCCESS, 'Advanced settings saved successfully');
expect(trackingService.trackTimeSpent).toHaveBeenCalled();
expect(trackingService.integrationsOnboardingCompletion).toHaveBeenCalled();
expect(workspaceService.setIntacctOnboardingState).toHaveBeenCalledWith(IntacctOnboardingState.COMPLETE);
expect(router.navigate).toHaveBeenCalledWith(['/integrations/intacct/onboarding/done']);
}));

it('should handle save when skipSelectiveExpenses is false', fakeAsync(() => {
const mockResponse = { ...advancedSettings };
advancedSettingsService.postAdvancedSettings.and.returnValue(of(mockResponse));
advancedSettingsService.deleteExpenseFilter.and.returnValue(of({} as SkipExport));
workspaceService.getIntacctOnboardingState.and.returnValue(IntacctOnboardingState.ADVANCED_CONFIGURATION);

component.advancedSettingsForm.get('skipSelectiveExpenses')?.setValue(false);

component.save();
tick();

expect(advancedSettingsService.postAdvancedSettings).toHaveBeenCalled();
expect(advancedSettingsService.deleteExpenseFilter).toHaveBeenCalledTimes(2);
expect(advancedSettingsService.deleteExpenseFilter).toHaveBeenCalledWith(1);
expect(advancedSettingsService.deleteExpenseFilter).toHaveBeenCalledWith(2);
expect(toastService.displayToastMessage).toHaveBeenCalledWith(ToastSeverity.SUCCESS, 'Advanced settings saved successfully');
}));

it('should handle save when not in onboarding state', fakeAsync(() => {
const mockResponse = { ...advancedSettings };
advancedSettingsService.postAdvancedSettings.and.returnValue(of(mockResponse));
workspaceService.getIntacctOnboardingState.and.returnValue(IntacctOnboardingState.COMPLETE);

component.isOnboarding = false;
component.save();
tick();

expect(advancedSettingsService.postAdvancedSettings).toHaveBeenCalled();
expect(trackingService.intacctUpdateEvent).toHaveBeenCalled();
expect(router.navigate).not.toHaveBeenCalled();
}));

it('should handle error when saving advanced settings', fakeAsync(() => {
const getError = () => new Error('Error');
advancedSettingsService.postAdvancedSettings.and.returnValue(throwError(getError));
JustARatherRidiculouslyLongUsername marked this conversation as resolved.
Show resolved Hide resolved

component.save();
tick();

expect(advancedSettingsService.postAdvancedSettings).toHaveBeenCalled();
expect(toastService.displayToastMessage).toHaveBeenCalledWith(ToastSeverity.ERROR, 'Error saving advanced settings, please try again later');
expect(component.saveInProgress).toBeFalse();
JustARatherRidiculouslyLongUsername marked this conversation as resolved.
Show resolved Hide resolved
}));
});
});
Loading