feat: Trim memo and date in exports

[ashwin1111]

Description

Please add PR description here, add screenshots if needed

Clickup

https://app.clickup.com/

Summary by CodeRabbit

• New Features

  • Enhanced memo generation for expense groups, ensuring clarity and consistency in terminology.
  • Improved flexibility in date handling for memo generation, accommodating multiple valid options.

• Bug Fixes

  • Refined memo construction logic to ensure uniqueness and accurate representation of expense details.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve modifications to the get_memo function within the apps/sage_intacct/models.py file. Key updates include renaming a string for consistency, enhancing conditional checks for date handling, and refining memo construction to ensure clarity and uniqueness. The function's logic has been adjusted to properly reflect the fund source and transaction date based on specific conditions, streamlining the memo generation process in expense reporting.

Changes

File Path	Change Summary
apps/sage_intacct/models.py	- Renamed string from "Corporate Credit Card expense" to "Corporate Card expense".
	- Updated conditional checks for ccc_export_date_type and reimbursable_export_date_type to allow 'current_date' and 'last_spent_at'.
	- Refined get_memo function logic to ensure correct fund source and conditional inclusion of transaction date.
	- Adjusted memo construction to account for existing memos, ensuring uniqueness.

Possibly related PRs

• fix: use the correct condition to test for CCT memos #552: The changes in this PR also modify the get_memo function in apps/sage_intacct/models.py, focusing on the logic for memo generation, which is directly related to the modifications made in the main PR.

Poem

🐰 In the meadow of expense, we hop and play,
With memos refined, brightening the day.
From "Corporate Credit" to a card more neat,
Each date now dances, a rhythmic beat.
Uniqueness shines in every report,
A joyful leap in our expense cohort! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Tests	Skipped	Failures	Errors	Time
282	0 💤	0 ❌	0 🔥	39.510s ⏱️

[github-actions]

Tests	Skipped	Failures	Errors	Time
282	0 💤	0 ❌	0 🔥	41.932s ⏱️