WIP: Add document support #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
added
enhancement
fwcd
force-pushed
the
document-group
branch
2 times, most recently
from
1f02a86
to
650ee4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1. We'd need to investigate how well this works in the Swift Playgrounds sandbox and whether we might be able to provide a different startup flow from the 'plain' file picker.
Also we'd want to handle the synchronization in a less ad-hoc way. One option would be to move to a
ReferenceFileDocument(like in this example) that we pass toEditorViewModeland then use as the source of truth for the raw recipe there.Finally it would be cool if we could get the menu bar items working (open, save etc.). This could be a Catalyst limitation too though.