Varrious fixes for errors found in fvwm3-output.log #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color commands have already been removed in favor of colorsets. This removes some commands that got missed in the removal.
Applications with spaces caused a bad style option because of missing quotes. This adds quotes around the application name to deal with applications with spaces.
ThomasAdam
requested changes
Nov 7, 2023
fvwm/virtual.c
Outdated
Comment on lines
1379
to
1394
| fvwm_debug(__func__, "Window is PanFrame top\n"); | ||
| return True; | ||
| } | ||
|
|
||
| if (is_pf_bottom) { | ||
| fvwm_debug(__func__, "Window is PanFrame bottom\n"); | ||
| return True; | ||
| } | ||
|
|
||
| if (is_pf_left) { | ||
| fvwm_debug(__func__, "Window is PanFrame left\n"); | ||
| return True; | ||
| } | ||
|
|
||
| if (is_pf_right) { | ||
| fvwm_debug(__func__, "Window is PanFrame right\n"); |
There was a problem hiding this comment.
These could do with staying around for now -- I still see weird things with different sized monitors and configurations where panframes can go wandering to different locations.
There was a problem hiding this comment.
Okay, they are back. I just do a lot of EdgeScrolling and my logs are getting filled with these messages.
If xdg wasn't able to find a valid icon, the icon would revert to a string that is not a valid icon path, causing fvwm to return an error. Add one final check to ensure that the icon path exists before using it.
somiaj
force-pushed
the
js/various-error-fixes
branch
from
2b4adca to
722af90
Compare
|
Awesome! Thanks, @somiaj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to clean up the error log file I found that: