Correct shadows on vertical titlebars #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
added
type:bug
|
Hey @hak-foo Thanks -- this looks OK to me. Just one thing -- please squash your two commits together; the comment correction is too minor to warrant a commit of its own in this case. |
hak-foo
force-pushed
the
jz/correct-shadows-on-vertical-titlebars
branch
from
3d54410 to
54a3106
Compare
|
Squashed commits. :) |
ThomasAdam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "relieved rectangle with rotation" code would highlight the bottom side of the rectangle, and shade the top when a 90 or 270 degree rotation was specified. This causes titlebars to be inconsistently highlighted.