Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove paket #205

Merged
merged 6 commits into from
Dec 14, 2023
Merged

chore: Remove paket #205

merged 6 commits into from
Dec 14, 2023

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Dec 14, 2023

Perhaps a hot take, but I'm really more in favour of removing Paket altogether.
As there is so little going on in this repository, NuGet should be fine here.

@nojaf nojaf requested a review from bartelink December 14, 2023 08:03
Argu.sln Outdated Show resolved Hide resolved
Argu.sln Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
nuget.config Outdated Show resolved Hide resolved
@bartelink
Copy link
Member

Thanks, this makes me happy!

@bartelink
Copy link
Member

Also consider collapsing samples, src and tests solution folders (def src and tests anyway)

@nojaf
Copy link
Collaborator Author

nojaf commented Dec 14, 2023

I'm not too concerned with details like sorting or dividing Directory.Packages.props into separate sections. If these matter to you, you're welcome to make changes and push to this branch. Just know that I use Argu occasionally and it's important for me that the fixes are updated on NuGet. I'm not as driven to address every meticulous detail.

Directory.Build.props Outdated Show resolved Hide resolved
@bartelink
Copy link
Member

Done. Assuming removing .tfignore didnt break anything I'm happy with it merging when you're happy

@nojaf
Copy link
Collaborator Author

nojaf commented Dec 14, 2023

Yup, looks good. Thanks for taking care of this!

@bartelink
Copy link
Member

.editorconfig added for fsx?, *proj and yml files (indent by 2 for last 2)

@nojaf
Copy link
Collaborator Author

nojaf commented Dec 14, 2023

Looks great. Thanks for going the extra mile here!

@nojaf nojaf merged commit dc7dcd3 into fsprojects:master Dec 14, 2023
4 checks passed
@bartelink bartelink mentioned this pull request Dec 14, 2023
bartelink added a commit to bartelink/Argu that referenced this pull request Feb 19, 2024
* chore: Replace Paket with NuGet.

* Ignore FSharp.Core and System.Configuration.ConfigurationManager by dependabot.

* Tidy xml files

* Add .editorconfig

* Apply rules to proj files

* reorder sln text

---------

Co-authored-by: Ruben Bartelink <[email protected]>
bartelink added a commit to bartelink/Argu that referenced this pull request Feb 28, 2024
* chore: Replace Paket with NuGet.

* Ignore FSharp.Core and System.Configuration.ConfigurationManager by dependabot.

* Tidy xml files

* Add .editorconfig

* Apply rules to proj files

* reorder sln text

---------

Co-authored-by: Ruben Bartelink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants