Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes #123

Closed
wants to merge 2 commits into from
Closed

Python 3 fixes #123

wants to merge 2 commits into from

Conversation

joka
Copy link

@joka joka commented Sep 6, 2013

To run mr.developer with pyhton 3.3 I needed these fixes.

joka added 2 commits September 6, 2013 17:47
Concatenating History.rst throws TypeError in setup.py.
The most simple python 2.5 compatible solution was to remove
all ut8 characters.
@fschulze
Copy link
Owner

fschulze commented Sep 9, 2013

For python 3 you have to use bootstrap2.py, updating the old bootstrap.py breaks the builds for older python versions (as you can see from the Travis failure of this PR).

The encoding problem should be fixed differently, we have 2013 and people should have their names spelled properly. I will look into it. I just wonder why this problem didn't show up so far in the tests. Which Python 3 version did you try it with and when did it show up (pip install maybe)?

@joka
Copy link
Author

joka commented Sep 9, 2013

The encoding problem should be fixed differently, we have 2013 and people should have their names spelled properly. I will look into it. I just wonder why this problem didn't show up so far in the tests. Which Python 3 version did you try it with and when did it show up (pip install maybe)?

I was using mr.developer with my python 3 project without problems. Since I deleted all eggs an rerun buildout this encoding error shows up.

I can reproduce this running the mr.developer delopment buildout with python 3.3.2 (buildout.python) and setuptools 0.9.8.

@fschulze
Copy link
Owner

It installs just fine for me with both pip and easy_install in a python 3.3.2 virtualenv.

@joka
Copy link
Author

joka commented Sep 10, 2013

It installs just fine for me with both pip and easy_install in a python 3.3.2 virtualenv.

strange, I have the same problem with or without virtualenv. Also updating setuptools to 1.1.4 does not help.
I will do some more debuging and add a issue instead of pull-request.

The same problem exists for me with deform, but they solved the problem with a try and catch block in setup.py:
https://github.com/Pylons/deform/blob/master/setup.py line 22-30.

@fschulze
Copy link
Owner

Could you try to add a .decode('utf-8') to the three .read() calls instead?

@joka
Copy link
Author

joka commented Sep 10, 2013

Could you try to add a .decode('utf-8') to the three .read() calls instead?

open(os.path.join("docs", "HISTORY.txt"), encode="utf-8").read()

yes, this should work with python 3, but actually it does not.
So i guess somehow my python build is broken and this is not a general problem.
Thanks for helping.

@joka joka closed this Sep 10, 2013
@fschulze
Copy link
Owner

Since you ran into the same issue, could you maybe help out on #127?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants