-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped all dependencies in the project #74
Conversation
WalkthroughThe pull request focuses on updating dependency versions in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pyproject.toml (1)
24-24
: Note the calendar versioning adoption in dependencies.Both
dask
andxarray
have moved to calendar versioning (CalVer):
dask[complete]>=2024.8
xarray>=2024.7
This change in versioning scheme might affect how you handle future updates. Consider:
- Updating your dependency management strategy
- Adjusting CI/CD pipelines for CalVer
Also applies to: 36-36
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml
(2 hunks)
🔇 Additional comments (3)
pyproject.toml (3)
2-2
: LGTM: Build system requirements updated safely.
The updates to hatchling
and hatch-vcs
are minor version bumps that should maintain backward compatibility.
29-29
:
Verify Numba compatibility with NumPy 2.0.
The update to numba>=0.60
needs special attention due to its deep integration with NumPy. Ensure Numba's JIT compilation continues to work with NumPy 2.0 array operations.
24-24
:
The updates to numpy>=2.0
and pandas>=2.2
introduce significant breaking changes that require careful verification:
- NumPy 2.0 includes array API changes and deprecations
- Pandas 2.2 has breaking changes in data frame operations
Please ensure:
- Test suite passes with the new versions
- Review the migration guides:
Also applies to: 31-31, 32-32
✅ Verification successful
✅ Limited NumPy usage with basic operations, no Pandas dependencies found
The codebase shows:
- NumPy usage is limited to basic array operations (zeros, array creation, logical operations) that are stable across versions
- No usage of deprecated or significantly changed NumPy APIs from 2.0
- No Pandas dependencies or usage found in the codebase
- No direct Dask imports found, suggesting Dask is likely used as a backend dependency
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for potential compatibility issues with numpy/pandas APIs
# Look for common patterns that might be affected by breaking changes
# Check for numpy array operations that might be affected
echo "Checking NumPy API usage..."
rg -l 'np\.(array|asarray|matrix|concatenate|stack|vstack|hstack|dstack|column_stack|row_stack|array_split|split|hsplit|vsplit|dsplit|reshape|resize|flatten|ravel|squeeze|expand_dims|broadcast_to|broadcast_arrays|atleast_1d|atleast_2d|atleast_3d|vander|tri|tril|triu|toeplitz|circulant|eye|identity|diag|diagflat|trace|diagonal|triangular|tril_indices|triu_indices|mask_indices|tril_indices_from|triu_indices_from|mask_indices_from|ix_|ogrid|mgrid|r_|c_|s_|index_exp|fill_diagonal|diag_indices|diag_indices_from)'
# Check for pandas operations that might need updates
echo "Checking Pandas API usage..."
rg -l 'pd\.(DataFrame|Series|concat|merge|join|pivot|pivot_table|melt|wide_to_long|get_dummies|cut|qcut|eval|query|rank|nlargest|nsmallest|pct_change|shift|tshift|rolling|expanding|ewm|window|resample|rolling_mean|rolling_std|rolling_var|rolling_min|rolling_max|rolling_sum|rolling_count|rolling_median|rolling_skew|rolling_kurt|rolling_apply|rolling_quantile|rolling_cov|rolling_corr|rolling_window|ewma|ewmstd|ewmvar|ewmcorr|ewmcov)'
Length of output: 1172
Script:
#!/bin/bash
# Let's examine the actual NumPy usage in the identified files
echo "=== NumPy usage in sandbox.py ==="
rg -A 2 'np\.' xcompact3d_toolbox/sandbox.py
echo -e "\n=== NumPy usage in genepsi.py ==="
rg -A 2 'np\.' xcompact3d_toolbox/genepsi.py
echo -e "\n=== NumPy usage in test_sandbox.py ==="
rg -A 2 'np\.' tests/unit/test_sandbox.py
# Let's also check for dask usage since it's the package being updated
echo -e "\n=== Dask usage patterns ==="
rg -l "import dask"
rg -l "from dask"
Length of output: 3921
Quality Gate passedIssues Measures |
Summary by CodeRabbit
New Features
Chores
hatchling
andhatch-vcs
.