Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3646 #3864

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Fix issue #3646 #3864

wants to merge 9 commits into from

Conversation

janclod
Copy link

@janclod janclod commented Aug 12, 2021

This should help future developers building on Linux using static libgit2 🤞

@janclod
Copy link
Author

janclod commented Aug 15, 2021

If this pull request is merged, issue #3646 and #3821 may be closed :)

Improvement: this pull request makes it possible to pass the LIBGIT_STATIC (found in the phoenix.pro file) variable when running qmake (e.g., qmake LIBGIT_STATIC=false). Developer will not need to manually edit the code to build using dynamic libgit2, possibly improving developers' experience 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants