-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: updated with features list #387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 101 101
Lines 3908 3908
=======================================
Hits 3804 3804
Misses 104 104 Continue to review full report at Codecov.
|
|
||
* Gives your applications a **structure** | ||
* **Environment** agnostic (runs in browser, server, and CLI) | ||
* **Rendering** library agnostic (integrates with React, Vue, and Preact) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need comma after "Vue"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexmiranda: Lord of grammar, please shine your light upon us :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that, thanks
README.md
Outdated
* **Environment** agnostic (runs in browser, server, and CLI) | ||
* **Rendering** library agnostic (integrates with React, Vue, and Preact) | ||
* **Composable** with multiple packages as needed | ||
* Each package focused on doing **one thing** well only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think "focused" should become either "focuses" or "is focused"
- The "...doing one thing well only" part reads weird. Maybe it should be "...doing one thing only and doing it well", or something shorter I can't come up with. Unix authors also couldn't :D https://en.wikipedia.org/wiki/Unix_philosophy#Do_One_Thing_and_Do_It_Well
README.md
Outdated
* **Rendering** library agnostic (integrates with React, Vue, and Preact) | ||
* **Composable** with multiple packages as needed | ||
* Each package focused on doing **one thing** well only | ||
* **Modular** architecture with Apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does "Apps" begin with capital letter? Shouldn't it be lowercase?
README.md
Outdated
* Each package focused on doing **one thing** well only | ||
* **Modular** architecture with Apps | ||
* Embraces **reactive programming** with RxJS | ||
* **Progressive** and easy to adopt it in existing applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need "it" in this sentence. Because the sentence already implies "It is" in the beginning:
"(It is) progressive and easy to adopt in existing applications".
README.md
Outdated
* **Environment** agnostic (runs in browser, server, and CLI) | ||
* **Rendering** library agnostic (integrates with React, Vue, and Preact) | ||
* **Composable** with multiple packages as needed | ||
* Each package is focused on doing **one thing** only and doint it well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing!!!
Very nice additions and clarifications! |
The characteristics were initially listed in #386.