Fix type hint errors in microgrid client #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout argument is expected to be an int, not a float. Signed-off-by: Daniel Zullo <[email protected]>
The tool mypy is not able to infer the types of the gRPC calls, so we need to cast them to the correct type in order to avoid the errors. Signed-off-by: Daniel Zullo <[email protected]>
github-actions
bot
added
the
part:microgrid
daniel-zullo-frequenz
added
the
cmd:skip-release-notes
llucax
approved these changes
Nov 10, 2023
Merged
via the queue into
frequenz-floss:v1.x.x
with commit Nov 10, 2023
b49eb89
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mypy type hint errors in microgrid client were fixed in an attempt to address #774 which might no longer need to be addressed as the suggestion is just moving the type hint error from
no-name-in-modulewhereprotobuf.*is imported tono-memberwhere it is used. Anyway I kept these commits in case we want to merge them, otherwise we can just close this PR and #774.